Problem/Motivation

Currently we have some string translations with t() using context and some are not using it.

We should change the existing string translation functions to use context.

One example with correct context is https://git.drupalcode.org/project/piwik_pro/-/blob/1.1.x/src/PiwikProSn....

Note that this could lead to missing translations for previous users because the source string changes. The impact should be minimal because most of the translated texts are only visible in the admin interface.

At the same time we can improve the form setting help texts and module readme.

Steps to reproduce

-

Proposed resolution

Add context to all string translations to make them easier to translate for the Piwik PRO specific context.

Remaining tasks

Add context to all string translations.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork piwik_pro-3496935

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heikkiy created an issue. See original summary.

dimas11 made their first commit to this issue’s fork.

dimas11 opened merge request !16

heikkiy’s picture

heikkiy commented
Status: Active » Reviewed & tested by the community

MR looks good.

heikkiy’s picture

heikkiy commented
Title: Missing context in string translations » Improve module help texts and add missing context in string translations
Issue summary: View changes
heikkiy’s picture

heikkiy commented
Status: Reviewed & tested by the community » Needs review

This needs a new review because I made more changes to the project readme.

hartsak’s picture

hartsak commented
Status: Needs review » Reviewed & tested by the community

  • heikkiy committed 58b6a7f4 on 1.2.x authored by dimas11 
    Issue #3496935 by heikkiy, dimas11, hartsak: Improve module help texts...
heikkiy’s picture

heikkiy commented
Status: Reviewed & tested by the community » Fixed

This is now fixed and will be released in 1.2.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.