Problem/Motivation

The <iframe> inside of the <noscript> doesn't have the required title tag. According to the WCAG https://www.w3.org/WAI/WCAG21/Techniques/html/H64 guidelines, each iframe should have a unique title tag.

Furthermore, I think we should also add the aria-hidden="true" attribute, because the content of the iFrame shouldn't be visible for screenreaders.

Proposed resolution

Add a title attribute to the iframe tag.

Remaining tasks

-

User interface changes

-

API changes

-

Data model changes

-

Issue fork piwik_pro-3487022

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

timohuisman created an issue. See original summary.

timohuisman opened merge request !9

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
Issue summary: View changes
Status: Active » Needs review

heikkiy made their first commit to this issue’s fork.

  • heikkiy committed dd3fc20e on 1.1.x authored by timohuisman 
    Issue #3487022 by timohuisman, heikkiy: Add title and aria-labels to...
heikkiy’s picture

heikkiy commented
Status: Needs review » Needs work

Marking this as Needs work because of the missing translation.

timohuisman opened merge request !10

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
Status: Needs work » Needs review
heikkiy’s picture

heikkiy commented
Status: Needs review » Needs work

Marking this as Needs work until the dependency injection part is changed.

timohuisman changed the visibility of the branch 3487022-add-title-and to hidden.

timohuisman changed the visibility of the branch 3487022-add-title-and to active.

  • heikkiy committed 988a3cef on 1.1.x authored by timohuisman 
    Issue #3487022 by timohuisman, heikkiy, dimas11: Allow translating...
heikkiy’s picture

heikkiy commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.