Currently when one visits admin/help/pirate, it reads "No help is available for module Pirate filter."

CommentFileSizeAuthor
#10 pirate-helper_function-2584025-10.patch592 bytesmakbul_khan8
#3 Pirate filter drupal8.png18.5 KBmonika.kadam1206
#3 pirate-corrected-route-path-and-added-help-text-2584025-3.patch820 bytesmonika.kadam1206
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sillygwailo created an issue. See original summary.

monika.kadam1206’s picture

monika.kadam1206 CreditAttribution: monika.kadam1206 as a volunteer and at Faichi Solutions Pvt Ltd commented
Assigned: Unassigned » monika.kadam1206
monika.kadam1206’s picture

monika.kadam1206 CreditAttribution: monika.kadam1206 as a volunteer and at Faichi Solutions Pvt Ltd commented
FileSize
pirate-corrected-route-path-and-added-help-text-2584025-3.patch820 bytes
Pirate filter drupal8.png18.5 KB

In hook_help() function their was full path but in D8 we need to add route instead of path.
So changed path to route.
Also the help text updated from readme file.
The patch is working. For more details I have attached the output screen short.
If anything needs to be updated let me know.

monika.kadam1206’s picture

monika.kadam1206 CreditAttribution: monika.kadam1206 as a volunteer and at Faichi Solutions Pvt Ltd commented
Assigned: monika.kadam1206 » Unassigned
Status: Active » Needs review
saurabh.tripathi.cs’s picture

saurabh.tripathi.cs CreditAttribution: saurabh.tripathi.cs as a volunteer and at Faichi Solutions Pvt Ltd commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Hi,
This patch works for me.Previously path was used in hook help but as per Drupal 8 standard route name should be used.
Verified.

sillygwailo’s picture

sillygwailo
Location Toronto, ON
CreditAttribution: sillygwailo as a volunteer commented

Pushed to the 8.x branch. This would be nice for the 7.x branch too.

sillygwailo’s picture

sillygwailo
Location Toronto, ON
CreditAttribution: sillygwailo as a volunteer commented
Status: Reviewed & tested by the community » Active
makbul_khan8’s picture

makbul_khan8 CreditAttribution: makbul_khan8 at Faichi Solutions Pvt Ltd commented
Assigned: Unassigned » makbul_khan8
makbul_khan8’s picture

makbul_khan8 CreditAttribution: makbul_khan8 at Faichi Solutions Pvt Ltd commented
Status: Active » Needs review
FileSize
pirate-helper_function-2584025-10.patch592 bytes

Created patch for D7 as per hook_help.

makbul_khan8’s picture

makbul_khan8 CreditAttribution: makbul_khan8 at Faichi Solutions Pvt Ltd commented
Assigned: makbul_khan8 » Unassigned

sillygwailo’s picture

sillygwailo
Location Toronto, ON
CreditAttribution: sillygwailo as a volunteer commented

Looks good. Committed with a small revision (to add a link).

makbul_khan8’s picture

makbul_khan8 CreditAttribution: makbul_khan8 at Faichi Solutions Pvt Ltd commented
Status: Needs review » Closed (fixed)

Updating status as fixed.