Libraries Usage causes Problem on detecting the version number. [#1908282]

I updated to 3.0 and downloaded the fresh version from GitHub of PHPExcel. After that it did not worked anymore. Long story quick: It seems that the changelog.txt of PHPExcel vontains @version ##VERSION## instead of something numeric. Your libraries rules check for a number. So librabries return alwas false on detecting if PHPExcel is there or not.

This is also in the 1.7.8 release of PHPExcel. I manually wrote 1.7.8 in the changelog instead of ##VERSION## and it could be loaded nicely.

Comment	File	Size	Author
#7	PHPExcel-changelog-version-number-1908282-7.patch	820 bytes	eft
#7
#5	PHPExcel-changelog-version-number-1908282-5.patch	456 bytes	eft
#5
#3	changelog_version_number-1908282-3.patch	820 bytes	mikran
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

wadmiraal CreditAttribution: wadmiraal commented 6 February 2013 at 09:08

Component:	Code	» Documentation
Assigned:	Unassigned	» wadmiraal
Category:	bug	» support
Priority:	Normal	» Critical
Status:	Active	» Fixed

Damn... I guess the author hasn't put up any commit hooks on Github.

If you download the code from Codeplex (where the project used to be hosted), the changelog.txt file is fine.

I'm going to put a note on the module page, so that developers either download the code from Codeplex, or put the version number in themselves. I could hard-code the version number in the Libraries info hook, but that would defeat the purpose of using the Libraries module in the first place, as I would lock developers in using the 1.7.8 version.

I'm opening an issue on Github as well, so the author updates the file :-).

Comment #2

wadmiraal CreditAttribution: wadmiraal commented 6 February 2013 at 09:14

Status:

Fixed

» Postponed

Marking as postponed.
Will mark as fixed when the version is added on Github.

Comment #3

mikran CreditAttribution: mikran commented 8 February 2013 at 11:39

File	Size
changelog_version_number-1908282-3.patch	820 bytes

As a temporary fix to .make file I did this:

; phpexcel
projects[phpexcel][version] = "3.0"
libraries[PHPExcel][type] = "library"
libraries[PHPExcel][download][type] = "get"
libraries[PHPExcel][download][url] = "https://github.com/PHPOffice/PHPExcel/archive/PHPExcel_1.7.8.tar.gz"
libraries[PHPExcel][patch][] = "http://drupal.org/files/changelog_version_number-1908282-3.patch"

I couldn't find codeplex url that can be used with .make files but the lines above work well.

Comment #4

wadmiraal CreditAttribution: wadmiraal commented 13 February 2013 at 10:01

Thanks for this. Mentionning it in the documentation.

Comment #5

eft CreditAttribution: eft commented 9 December 2013 at 17:53

Issue summary:

View changes

File	Size
PHPExcel-changelog-version-number-1908282-5.patch	456 bytes

Attached is another patch for the current branch of PHPExcel library.

Comment #6

wadmiraal CreditAttribution: wadmiraal commented 10 December 2013 at 07:11

Thanks eft ;-)

Comment #7

eft CreditAttribution: eft commented 6 March 2014 at 05:16

File	Size
PHPExcel-changelog-version-number-1908282-7.patch	820 bytes

And yet another patch for latest commits to develop branch.

Comment #8

wadmiraal CreditAttribution: wadmiraal commented 6 February 2015 at 11:21

Status:

Postponed

» Fixed

Good news everyone.

I noticed the PHPExcel maintainers started putting the version information in the changelog.txt file, just not where you would expect it. I updated the way the version number is retrieved for Libraries API, and it works. No more need to manually hack the changelog.txt file !

Fix is on dev, and will be published with release 7.x-3.8.