phpbb2drupal is using some techniques that are now deprecated - two that immediately show up are that DynamicMigration is unnecessary and Migration should be used directly, and migration constructors should consistently pass an arguments array.

It's actually broken now - although the proper machine names are in the migrate_status table, drush ms fails with messages like "No migration found with machine name phpbb__User" and ultimately a failure to sort the migration list. I haven't diagnosed this fully yet, it may be that the Migrate module could be fixed for better backwards-compatibility, but if the problem is on the phpbb2drupal side I'll open a separate issue.

Comments

mikeryan’s picture

As Jeremy's suggestion, I'll do this work for now in a feature branch, 7.x-3.x-2.6, to be merged back when stable.

mikeryan’s picture

Changes so far:

Replaced DynamicMigration with Migration
Consistently pass $arguments as migration constructor arguments
Group name is now saved at registration time, doesn't need to be done at construction time

I believe this is the minimum necessary to make things work for phpBB 3 imports, with no deprecated messages - I'm dealing with a phpBB 2 dump, so I need to deal with #2066319: Support phpBB 2 on Drupal 7 before I can have a fully working environment and test this.

mikeryan’s picture

Status: Active » Fixed

Looking good to me, so closing - anything specific that arises should be a separate issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nFusionCo’s picture

So which versions is this fixed in? Because I'm using phpbb2drupal 7.x-3.0+4-dev and tried it with Migrate 7.x-2.6-rc1 & 7.x.2.dev & 7.x.2.5 and the import fails right at the start with these depreciation issues and machine name issues.

mikeryan’s picture

It's in feature branch 7.x-3.x-2.6... @JeremyFrench, OK to merge back into 7.x-3.x? Or would it be worth a new major version 7.x-4.x?

JeremyFrench’s picture

Think New Major Is Good Idea.

mikeryan’s picture

Version: 7.x-3.x-dev » 7.x-4.x-dev

7.x-4.x branch pushed, added -dev release (not yet built).