HI,

The current release is a big step forward.
Logical names and locations of configuration.
i love it !!

I will regularly post the results of my tests here.
It will be in a pdf.
It will contain new questions/remarks, but also existing questions / remarks that are still open for me.

That way you do not have to go trough multiple issues/posts to get an overview of my findings.

It will be dated and it will contain the release version.

The first one being : 01-05-2020 (07487c25)
As in the top of the pdf.

Regards,

Hans

Comments

jhmnieuwenhuis created an issue. See original summary.

nathaniel’s picture

Awesome, thanks for the feedback / testing.

14 - "Page: Albums grid" can contain albums from any user. Each user has their own weight sort order for albums. The view can be edited to add the "Album weight" under sort criteria if needed, but it doesn't make sense to include it as a default. For example if a user added an album a year ago that has a weight of 0 it would still appear near the top of the list today.

15 - I decided to remove the "Page: Album" view and use the node page instead (it is more flexible and integrates with other modules better, like pathauto for example). I still have some test code using that view when I run the photos test suite, so, I can move it to a test module if needed or leave it there as optional / disabled, but that sounds like it might be confusing, so it might be best to remove it.

16 - In pathauto settings (/admin/config/search/path/settings): check "Photo" under "Enabled entity types" and save. We should probably include this note somewhere in the documentation under preparation or setup.

17.1 - This was a design change and how it works now. The view can be created for example in "Block: Album images" and displayed on the node page. We should be able to update the "Album photos image list view" option to include other views. I'd like to only include photos views, but I haven't quite figured that out yet - there could be some other bugs with this feature. An alternative option might be to create a block from the view that you want to use and display that on the /node page for type photos. Note we might want to move this to advanced settings and describe what it is supposed to do a bit better. (I'll update this feature today.)

nathaniel’s picture

A couple more notes:

We might be able to add an option for album link. Default to the node page, then allow selecting a view similar to the current select list for the "Album photos image list view" option under display settings. That should work, so you can set it to the /photos/%node view page instead.

We could delete the photos pathauto optional install config and change node to /photos/[node:nid] so the paths/breadcrumbs match up with the default photo path.

jhmnieuwenhuis’s picture

If i could just configure the link that the album cover points to.
Then it could point to any view i create.

I tried using an extra field of type link ( core link module enabled )
in the view add that link field just before album cover.

Then rewrite results for album cover field.

- custom link and link = {{ link_field }}

But that does not work.

Hans

jhmnieuwenhuis’s picture

We might be able to add an option for album link....

That would be great !!

I did sent my previous comment before reading your last comment...

nathaniel’s picture

I think that is going to work! Added an option under the advanced tab called "Override default album link".

Note that it only works with views pages that have %node as an argument and cache will likely have to be cleared after changing the setting.

jhmnieuwenhuis’s picture

Great !!!
That works for me.

I did some elementary testing and it works fine.

I'll test some more today and send another report at the end of my day ( and the start of yours )

jhmnieuwenhuis’s picture

StatusFileSize
new37.18 KB
new20.79 KB

One major issue.

I started testing with a media field instead of an image field.

Then i noticed that the upload existing media is no longer available on : /node/[nid]/photos
See old (mediaworks.png) and new screenshot (no_media.png )

I can still upload media one by one by using: /admin/content/photos.
That's fine for now for testing, but not for production.

I suppose the link with the module : Media Library Form Element is broken....

Regards,

Hans

jhmnieuwenhuis’s picture

StatusFileSize
new51.99 KB

Just saw that when i enable plupload, the add media option is also shown.

See PluploadAddMedia.png

Regards,

Hans

jhmnieuwenhuis’s picture

StatusFileSize
new39.23 KB

Latest Bugs, Questions, Remarks
See attached pdf ( BugsQuestionsRemarks_2020_0502.pdf )

jhmnieuwenhuis’s picture

Forget point 19.
You answered that one before.

jhmnieuwenhuis’s picture

Have been testing all day.
Love the way the module is setup now and it's configurability !!

I was able to set it up the way i want to use it.

Also tested the default configuration.

The only thing that maybe should be changed is the settings tab of Structure/Photos.
I think the correct location for the settings tab would be configuration/Photos.
And leave manage fields, manage form display and manage display in /structure/photos.
But that is nitpicking ;-)

Regards and thanks for all the good work !!

I haven't heard from you for a few days.
Hope everything is fine with you and your family.

Hans

jhmnieuwenhuis’s picture

StatusFileSize
new31.99 KB

Attached find my latest findings.
Previous pdf's can be discarded.

jhmnieuwenhuis.com is now using the latest version

Regards,

Hans

jhmnieuwenhuis’s picture

nathaniel’s picture

Thanks again for the feedback! Adding some notes here.

26. I think you are seeing the node reference link for "Album ID" /admin/structure/photos/display. We can add an option for format "Photo album" that is the title/link, maybe call it label or title. Note that currently only the cover option is working. Then we can default that link to the node and override it with the advanced option when set.

27. Yes, the blocks were removed, so let's remove the default block view mode.

28. In the code I think there are two conditions to display the field to add existing media:
- 1. The media_library_form_element module must be enabled.
- 2. A media field must be selected for the upload option "Default multi-upload field".
Maybe we can add a note in the field description or change the wording a bit.

29. Yes, sounds good. I'll work on adding a couple options for those under the advanced tab.

jhmnieuwenhuis’s picture

26: Good idea !
27: Ok
28: Ok
29: Test it, works fine !!

Thanks !

jhmnieuwenhuis’s picture

StatusFileSize
new38.17 KB

Latest findings in BugsQuestionsRemarks_2020_0508.pdf

Regards,
Hans

jhmnieuwenhuis’s picture

I saw that you moved the settings, nice !!

I am not sure but do you think config/media/photos is the correct location ?

Since one can use only images and no media.
Isn't config/photos a better location ?

Regards,
Hans

nathaniel’s picture

I'm still trying to find the documentation, but long ago I remember reading something about using existing sections if possible instead of creating new ones. Media seems the most appropriate out of the default sections.

/config/development
/config/media
/config/content
etc.

Otherwise it would be /config/photos/photos ?

jhmnieuwenhuis’s picture

If you have to use an existing section then media would be the best.

Regards,
Hans