Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Could you please add the validation for indian phone numbers, If thats out of way for you I can provide the patch.
Comment | File | Size | Author |
---|---|---|---|
#6 | phone.in_.test | 1.18 KB | nitvirus |
#6 | [Support-for-indian-numbers]-[2161669].patch | 705 bytes | nitvirus |
Comments
Comment #1
kscheirerThey're probably going to need a patch! India should definitely be supported, there is quite a lot of Drupal going on there.
I notice India is listed in countries.txt, but doesn't actually seem to be supported in the phone_countries() list.
The above is in reference to phone-7.x-1.x, I haven't check out the differences to 7.x-2.x yet. But I think Indian support should be able to go right into the 1.x branch without having to wait on 2.x.
Comment #2
kscheirerAfter taking a look at 7.x-2.x the quickest solution for indian support is still a quick patch against 7.x-1.x.
However, the 7.x-2.x branch is based on a more mature PHP library that already supports India, so making that version of the module operational is a much better strategy.
Comment #3
nitvirus CreditAttribution: nitvirus commentedwhat I understand is: I can use the 7.x-2.x branch for india support.
For 7.x-1.x branch should I make a patch?
Thanks,
Nitish
Comment #4
kscheirernitvirus, if you have time I'm sure the maintainers would welcome a patch for 7.x-1.x. Make sure to set this issue to "needs review" when there is code available.
But to answer your question, the 7.x-2.x branch does support India already, but the module itself may not be finished yet.
Comment #5
nitvirus CreditAttribution: nitvirus commentedOk kscheirer,
I am assigning the issue to myself and would upload the patch soon.
Thanks. :D
Comment #6
nitvirus CreditAttribution: nitvirus commentedHi,
I have made a patch for support of Indian number.
Maybe its a noob question but:
How can I add phone.in.inc in "includes/" and phone.in.test in "test/" folder?
I am attaching the patch file as such and putting the issue to "needs review". But the module needs phone.in.inc file and phone.in.test, and I am unable to attach the 'phone.in.inc' should I comment the code here?
Thanks
Comment #7
nitvirus CreditAttribution: nitvirus commented