Hi, Matslats.

I refactored a little the code so we can avoid sending emails if there is no new content.

Also, I added an option in the settings page so the administrator can decide if the digest mail should contain a link to let the users change their settings.

And finally I fixed the problem mentioned in #5 on #2832284: Fix Digest email empty.

Talking about the patches, I don't mind providing them even if in the end you prefer a different fix and don't use them, This is because in this way I can get the patches dynamically using composer. So I can continue working on my project even if you haven't yet the chance to check the issue. :-)

I was thinking what is the best way to add tests to the module, right now is hard testing it even manually, I will think about this and provide a patch later this week.

Thank!

CommentFileSizeAuthor
#2 2832993-email-empty.patch6.88 KBgnuget
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gnuget created an issue. See original summary.

gnuget’s picture

Status: Needs work » Needs review
FileSize
6.88 KB

Patch attached.

matslats’s picture

Priority: Critical » Major

Lovely patch
Committed and pushed.
I also declared the new variable and injected the AccountSwitcher

gnuget’s picture

Status: Needs review » Fixed

Great!

Thanks!

matslats’s picture

Status: Fixed » Closed (fixed)