Closed (fixed)
Project:
Permissions by Term
Version:
3.1.19
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
19 Oct 2022 at 08:34 UTC
Updated:
27 Oct 2023 at 10:49 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
reinchekComment #3
reinchekComment #4
reinchekJust a brief description of what i did inside the permissions_by_terms_parents.patch
- Added only_parents item inside $form array, SettingsForm.php:a
- Then, before getting all terms (from multiple vocabularies or from one) checks if the only_parents is true (default value FALSE):
Comment #5
reinchekComment #7
marcoliverHi reinchek, thanks for your patch!
I went ahead and created an issue fork. The patch applied fine. I made some slight modifications (using
$this->t()throughout the settings form now; made the description of the checkbox a bit more self-explanatory).Feel free to take a look if you are happy with these changes.
Comment #9
reinchekHi @marcoliver,
I fully agree with the proposed changes (I thought I had applied them myself, but apparently I mixed them up when creating the patch). Indeed, thank you for taking the trouble to look and fix those unclean portions of code!
Comment #11
marcoliverThanks! I merged the changes just now. New release forthcoming.
Comment #12
reinchekGreat! thank you!