Problem/Motivation

I composer-required the module in a PHP 7.0-based site, but was greeted with a great big fatal error. Only after that I saw that at the top of the project page there is a quote stating the module requires PHP 7.1. Telling me to RTFM is completely legitimate, although I would like to propose some changes anyway:

Proposed resolution

  1. Make the PHP minimal requirement explicit. I think if it's added to the info.yml, it will be automatically picked up in the generated composer.json too, although I am not 100% sure.
  2. Change the quote on the project page to a bold-face paragraph instead (although I think this is less relevant if the first point is adressed).

Remaining tasks

  1. Agree this is a good idea
  2. Create a patch
  3. Review
  4. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

eelkeblok created an issue. See original summary.

eelkeblok’s picture

Issue summary: View changes
jepster_’s picture

Assigned: Unassigned » jepster_
Status: Active » Needs work

jepster_’s picture

Status: Needs work » Fixed

@eelkeblok: Yep, that's a good idea. I don't know, why I have not done that before. The requirement is now added to the composer.json file (since PbT version 8.x-2.15). Please be so kind and re-check and re-open this issue, if you have any further notices.

jepster_’s picture

Status: Fixed » Closed (fixed)
jepster_’s picture

Assigned: jepster_ » Unassigned