This limit prevents admin to enter more than 8-10 users?

Is there a particular reason for such a small limit, performance concerns maybe?

CommentFileSizeAuthor
#10 allowed-users-limit-updated-3013330-10.patch559 bytesrwam
#5 alowed-users-limit.patch515 bytesbranislav radovanovic

Comments

Bane357 created an issue. See original summary.

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented

There is no reason for that. So long we have not needed more characters and you are the first with that issue. Do you like to provide a patch?

branislav radovanovic’s picture

branislav radovanovic commented

Hi Peter first of all than you for this great module it saved me a lot of time. I will submit a patch gladly however I've never done it before nor is my account confirmed yet - not sure if this is a problem? Can you give me some starting points?

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented
Status: Active » Postponed (maintainer needs more info)

Hi Bane, I am glad to read your feedback! :)

To extend your users file, you can just go into the file permissions_by_term/permissions_by_term.module and check around line 170. There's the array $form['access']['user'] with the size attribute. You can specify the size here, if you need more. Also you can check the Drupal form api for options regarding this field type. See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21....

A tutorial regarding patch creation via Git, can be found at https://mobilefish.de/creating-patch-git.

You are also welcome to fork the Permissions by Term module and create pull request on Bitbucket (make sure to use the 8.x-2.x Git branch): https://bitbucket.org/peter_majmesku/permissions_by_term/src/8.x-2.x/

The last way (pull request), is the more modern way compared to the old-fashioned Drupal patch creation.

branislav radovanovic’s picture

branislav radovanovic commented
StatusFileSize
new alowed-users-limit.patch515 bytes

Hi Peter here's a patch, but I'm kind of stuck on how to fork it on bitbucket?

I've created account there, added my SSH key, clone the repo, made changes and extracted the patch.

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented
Status: Postponed (maintainer needs more info) » Fixed

Thanks for the patch. Fixed in release 8.x-2.4. See release note: https://www.drupal.org/project/permissions_by_term/releases/8.x-2.4

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented
Status: Fixed » Closed (fixed)
rwam’s picture

rwam commented 
+++ b/permissions_by_term.module
@@ -174,6 +174,7 @@ EOT;
+      '#maxlenght'               => false,

Should be #maxlength, shouldn't it?

rwam’s picture

rwam commented
Version: 8.x-2.3 » 8.x-2.4
StatusFileSize
new allowed-users-limit-updated-3013330-10.patch559 bytes

Attached updated patch with the spelling fix.

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented

Outh.. yes. The fix is contained in release version 8.x-2.5.