The description is outdated. PbT has more features and the description confuses a bit. See attached screenshot.

CommentFileSizeAuthor
#2 Permissions_by_Term_Settings___Permissions_by_Term_Testground.png126.66 KBPeter Majmesku
Add_term___Permissions_by_Term_Testground_🔊.png162.54 KBPeter Majmesku
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Peter Majmesku created an issue. See original summary.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented
FileSize
Permissions_by_Term_Settings___Permissions_by_Term_Testground.png126.66 KB

One additional sentence, which can be deleted.

dakku’s picture

dakku CreditAttribution: dakku commented

Peter, I can push these changes later today.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented

That would be nice J. :)

  • dakku committed 8a7e4de on 2921403-updates 
    Issue #2921403 by Peter Majmesku: Update description in term add/edit...
dakku’s picture

dakku CreditAttribution: dakku commented

Hi Peter,
Can you check and merge this?
http://cgit.drupalcode.org/permissions_by_term/commit/?h=2921403-updates...

Once you are done, we can delete the 2921403-updates branch..

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented
Status: Active » Needs work

There's something wrong. I get an invalid branch error. Could you please check?

dakku’s picture

dakku CreditAttribution: dakku commented

Thats odd..
Try this: http://cgit.drupalcode.org/permissions_by_term/tree/?h=2921403-updates

here is a link to direct commit id:
http://cgit.drupalcode.org/permissions_by_term/commit/?id=8a7e4de

dakku’s picture

dakku CreditAttribution: dakku commented
Status: Needs work » Needs review
Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented

Thanks.

In modules/permissions_by_term/src/Form/SettingsForm.php:34 you have wrote a TODO:

TODO: Make long strings consistent.

What do you mean with this? I like NOWDOC in PHP for long strings and this is standard. See http://php.net/manual/en/language.types.string.php#language.types.string....

Something like

'#description' => t('Enter a comma-seperated list of user names who') . ' ' .
      t('will can access content tagged with this term.'),

I don't like. Because a sentence must be translated in 2 parts. That's ugly.

  • 5e22038 committed on 8.x-1.x 
    Issue #2921403 by Peter Majmesku, dakku: Update description in term add/...
Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented
Status: Needs review » Fixed

I have tweaked the code and spelling a bit and commited the changes to the Git dev branch.

Please re-open this issue, if you have any objections.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.