Make the D8 module can be installed.

CommentFileSizeAuthor
#11 2142579-drupal8-11.patch1.62 KBjian he
#11 interdiff.txt634 bytesjian he
#10 2142579-drupal8-10.patch1.53 KBjian he
#8 2142579-drupal8-8.patch9.28 KBjian he
#8 interdiff.txt1.55 KBjian he
#4 2142579-drupal8-4.patch7.72 KBjian he
#4 interdiff.txt1.61 KBjian he
#2 2142579-drupal8-2.patch6.31 KBjian he
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Related issues: +#2293939: Replace the payment API with Payment 8.x-2.x
jian he’s picture

jian he CreditAttribution: jian he commented
Status: Active » Needs review
FileSize
2142579-drupal8-2.patch6.31 KB

This is for drupal 8, so don't mind on drupal 7 auto testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2142579-drupal8-2.patch, failed testing.

jian he’s picture

jian he CreditAttribution: jian he commented
FileSize
interdiff.txt1.61 KB
2142579-drupal8-4.patch7.72 KB

fix payment_ubercart_uc_payment_method.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Druid commented
Title: Drupal 8 version » [META] Drupal 8 version

Let's keep this issue as a meta issue and create sub-issues for porting specific parts of the module. Note that all code must have full test coverage.

jian he’s picture

jian he CreditAttribution: jian he commented
Title: [META] Drupal 8 version » Initialize the D8 version
Issue summary: View changes
Parent issue: » #2626290: [META] Port payment_ubercart to Drupal 8
jian he’s picture

jian he CreditAttribution: jian he commented
Related issues: -#2293939: Replace the payment API with Payment 8.x-2.x
jian he’s picture

jian he CreditAttribution: jian he commented
FileSize
interdiff.txt1.55 KB
2142579-drupal8-8.patch9.28 KB

Add testing suite.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Druid commented

As I said before, please split this off in separate issues and be more specific about what parts of the module you are converting. This is hard to review and test.

Also, every little bit of code requires its own test, and make sure all code complies with the coding standards. Use Coder if you have to. 

  1. +++ b/payment_ubercart.permissions.yml
@@ -0,0 +1,3 @@
+  title: 'Administer payment for ubercart'

    Ubercart is a name and as such should be capitalized. 

  2. +++ b/payment_ubercart.permissions.yml
@@ -0,0 +1,3 @@
+  restrict access: true

    Why are you adding this? 

  3. +++ b/src/Form/SettingsForm.php
@@ -0,0 +1,50 @@
+      '#title' => t('Delete payments when order deleted'),

    Why are you rewriting all these UI texts?

If you port something, do not change these small things everywhere.

jian he’s picture

jian he CreditAttribution: jian he commented
Title: Initialize the D8 version » Make D8 version module can be installed
Issue summary: View changes
FileSize
2142579-drupal8-10.patch1.53 KB

please split this off in separate issues and be more specific about what parts of the module you are converting. This is hard to review and test.

Oh, I understand now.
I changed the issue title and this patch only have small changes.

jian he’s picture

jian he CreditAttribution: jian he commented
FileSize
interdiff.txt634 bytes
2142579-drupal8-11.patch1.62 KB

Fix coding standard.