There is coding standard issue in the following project.

git clone --branch 8.x-2.x https://git.drupal.org/project/payment.git

Please do check attached file.

CommentFileSizeAuthor
#7 interdiff_5-7.txt51.1 KBadityasingh
#7 2874906-7.patch356.68 KBadityasingh
#5 coding-standard-2874906-5.patch347.24 KBrajandro
#3 pending_coding_standard_errors.txt5.61 KBrajandro
#3 coding-standard-2874906-3.patch350.94 KBrajandro
#2 payment-8.x-2.x_core_9.1.x.txt225.58 KBrajandro
coding-standards.txt332.56 KBcmsMinds
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cmsMinds created an issue. See original summary.

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: cmsMinds » rajandro
Related issues: +#2867280: Convert module to use short array syntax (new coding standard).
FileSize
payment-8.x-2.x_core_9.1.x.txt225.58 KB

Since this is a very old issue, so adding the new Coding standard violation message here that needs to address.

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: rajandro » Unassigned
Status: Needs work » Needs review
FileSize
coding-standard-2874906-3.patch350.94 KB
pending_coding_standard_errors.txt5.61 KB

Adding a patch to fix for the coding standard issue. Except for a few commenting and depreciation errors rest of the issue has been resolved. For the pending scenario as mentioned in the attached file, we need to decide we will remove the unnecessary parameter or not.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

This has syntax errors and will require a reroll now.

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
coding-standard-2874906-5.patch347.24 KB

Re-rolled the patch and checked the module for any syntax error, didn't find any for the new patch. However, we still need to address the comment of #3
This patch address array format, spacing issue. However, I believe it's better to split this ticket per rule basis and fix it accordingly.
After this patch, if it still fails I will break it into child issues based on rules.

adityasingh’s picture

adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

Working on this.

adityasingh’s picture

adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2874906-7.patch356.68 KB
interdiff_5-7.txt51.1 KB

Fixed as per drupal coding standard

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
Status: Needs review » Reviewed & tested by the community

  • Berdir committed 138a648 on 8.x-2.x 
    Issue #2874906 by rajandro, adityasingh, cmsMinds: Coding Standard Issue
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Issue tags: -Coding standard issue +Coding standards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.