Hi Folks,

I've downloaded and installed this and am ready to work on a theme using it. However, I am worried about this presuming my changes will be overridden if I/you update the theme in the future a-la "hacking core".

What's the workflow in this case? Should I sub-theme from it? Clone the theme and rename it? Use it as is and expect there will be no updates for it? Use the github version and not update?

Thanks a lot.

Comments

markconroy created an issue.

markconroy’s picture

markconroy commented
unsettlingtrend’s picture

unsettlingtrend
Primary language English
commented

This is a concern of mine as well. I can see that it's a subtheme of classy. Should we just be expected to rename it ourselves once we have what we want and break the connection to the actual contrib module?

EvanLovely’s picture

EvanLovely commented

This is a starting off point that is meant to be altered; it depends on `p2-theme-core` as a node dependency that gets updated with new changes.

markconroy’s picture

markconroy commented

Thanks Evan.

If I make a change to atoms > typography > text > headings.scss and later there is an update to the theme, will that file be overridden?

Similarly, if I make a change to block--system--branding-block.html.twig well that be overridden?