First paramater of function hook_pathauto_pattern_alter() is documented as string but in fact it is an object.

CommentFileSizeAuthor
#12 doc-pathauto.png185.37 KBamietpatial
#11 interdiff.2904456.9-11.txt703 bytesdatvance
#11 2904456-11.pathauto.Wrong-documentation-in-hookpathautopatternalter.patch1.32 KBdatvance
#9 interdiff.txt756 bytesDinesh18
#9 2904456-9.patch776 bytesDinesh18
#2 wrong-function-doc-2904456.patch723 bytesjunkuncz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

junkuncz created an issue. See original summary.

junkuncz’s picture

junkuncz CreditAttribution: junkuncz commented
FileSize
wrong-function-doc-2904456.patch723 bytes
junkuncz’s picture

junkuncz CreditAttribution: junkuncz commented
Status: Active » Needs review
junkuncz’s picture

junkuncz CreditAttribution: junkuncz at Mirum Agency commented
Dinesh18’s picture

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

#2 Looks good to me. +1 to RTBC

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented
Title: Wrong function documentation » Wrong documentation in hook_pathauto_pattern_alter

+1
Small but very useful fix. Makes a lot easier to debug code.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented
Related issues: +#2692205: Update hook_pathauto_pattern_alter() documentation

This issue relates to #2692205: Update hook_pathauto_pattern_alter() documentation

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Needs work

It's not just any object, it's a pattern config entity, so we should use the correct type.

Dinesh18’s picture

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented
Status: Needs work » Needs review
FileSize
2904456-9.patch776 bytes
interdiff.txt756 bytes

Here is the updated patch and interdiff as per comment #8

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer commented

Tested the patch and it looks good.

datvance’s picture

datvance CreditAttribution: datvance commented
FileSize
2904456-11.pathauto.Wrong-documentation-in-hookpathautopatternalter.patch1.32 KB
interdiff.2904456.9-11.txt703 bytes

Also, 'type' key should be 'bundle' in $context documentation. new patch and interdiff attached.

amietpatial’s picture

amietpatial CreditAttribution: amietpatial commented
Status: Needs review » Reviewed & tested by the community
FileSize
doc-pathauto.png185.37 KB

I have checked the documentation it's fine.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented

Tested the latest patch and applies cleanly.

amietpatial’s picture

amietpatial CreditAttribution: amietpatial as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Reviewed & tested by the community » Closed (duplicate)

There is an earlier issue regarding this hook in #2692205: Update hook_pathauto_pattern_alter() documentation. I'll close this issue as a duplicate, so we can focus our effort in the related issue.

I added you as contributors in the related issue, so you are credited correctly when the issue is committed.