Problem/Motivation

When upgrading to PHP8, I got this warning:


FILE: path_breadcrumbs/path_breadcrumbs_ui/path_breadcrumbs_ui.module
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 949 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $buttons is optional, while parameter $form_name is required.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Upgrade server to PHP8, then run a drush command and see warning.

Proposed resolution

Update parameters in function declaration.

CommentFileSizeAuthor
path_breadcrumbs-php8.patch948 bytesshkiper

Issue fork path_breadcrumbs-3277689

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shkiper created an issue. See original summary.

arx-e’s picture

arx-e CreditAttribution: arx-e commented

I got this warning with php 8.1 on every page. I applied the patch and I don;t see any issues.

bserem made their first commit to this issue’s fork.

bserem opened merge request !1

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Needs review » Reviewed & tested by the community

Tested and is fixing the issue. Thanks

VladimirAus’s picture

VladimirAus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: VladimirAus at Tomato Elephant Studio commented

+1. RTBC