Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork password_strength-3441705

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chaitanyadessai created an issue. See original summary.

chaitanyadessai opened merge request !10

chaitanyadessai’s picture

chaitanyadessai commented
Assigned: chaitanyadessai » Unassigned
Status: Active » Needs review

Please review MR.

mitthukumawat’s picture

mitthukumawat commented
Status: Needs review » Needs work

It only resolved the \Drupal calls should be avoided in classes, use dependency injection instead errors. We should address all coding standard issues raised by phpcs.

silvi.addweb made their first commit to this issue’s fork.

mitthukumawat’s picture

mitthukumawat commented
Status: Needs work » Reviewed & tested by the community

Awesome, it resolved all phpcs coding standard issues. It can be merged now.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Needs work

The advice from #4:

We should address all coding standard issues raised by phpcs.

Is not great advice, unfortunately. There's an existing issue at #2995816: Coding standard to already do that. The 2 issues overlap and change things differently which makes it harder to pick what to do.