If using a strict composer workflow for Drupal 8 the composer manager module causes more issues than it solved. The dependency should not be enforced, but maybe recommended via documentation.

CommentFileSizeAuthor
#2 remove_dependency_on-2633090-2.patch282 bytestimmillwood
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
FileSize
remove_dependency_on-2633090-2.patch282 bytes

Adding patch

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Active » Needs review

This is causing us issues!

We don't want composer_manager, this module doesn't need it, and you're forcing us to install it.

bendohoomph’s picture

bendohoomph CreditAttribution: bendohoomph commented

Yes, would like to see this patch added to this module. It's a needless dependency and is trivial to remove. Please get this in there, module maintainers!

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
CreditAttribution: johnpicozzi at Oomph, Inc. commented
Status: Needs review » Reviewed & tested by the community

Tested this patch and it works...

I agree if a module has dependencies outside of Drupal it should have instructions to install it with both composer require and composer manager, similar to the Address module. Making Composer Manager a requirement actually ended up breaking my site with an error.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Category: Bug report » Task

Thanks for providing a description and the patch and reviews!

I'm not really knowledgeable enough to review this, but from the description it seems to me more like a task/feature than a bug. If others feel it really is a bug can you clarify how relying on composer_manager in D8 is a bug?

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

composer_manager was never meant to be depended on. It was a helper module that is now deprecated.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

RTBC +1 Any plans to get this committed

bendohoomph’s picture

bendohoomph CreditAttribution: bendohoomph commented

+1 Again, Maintainers! Are you there? This doesn't appear to be "Actively Maintained" as this issue is trivial, wanted, and unfixed!!

C'mon guys!

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein at CivicActions commented
Status: Reviewed & tested by the community » Fixed

I am pushing this now. My apologies for the delay.

bendohoomph’s picture

bendohoomph CreditAttribution: bendohoomph commented

Thank you!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.