password_strength_score_list creates an array of strength labels but relies on php's assigned array keys as internal identifiers of those strengths. This seems unreliable.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

Status: Active » Needs review
FileSize
1.01 KB
coltrane’s picture

I'm in favor of this and will likely commit it as is.

But, while you raise this point I'm curious for your input on whether there's value in having variable names/IDs or configurable range of strengths? These values map into the ZxcvbnPhp library itself so changing the range would require a change there too.

coltrane’s picture

Status: Needs review » Needs work

(Edited to remove prior comment, it was actually about 2393873)

coltrane’s picture

Status: Needs work » Fixed

Committed. Any bigger changes can go in a new issue.

  • coltrane committed 74788d4 on 7.x-1.x authored by greggles
    Issue #2395145 by greggles: use real array keys in strength levels
    
greggles’s picture

I think there might be a desire by some people some day to have more granular control of the strengths, but that feels like a really low value thing that 90% of the module users don't want.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.