Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
password_strength_score_list creates an array of strength labels but relies on php's assigned array keys as internal identifiers of those strengths. This seems unreliable.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2395145_constants_and_assigned_array_keys.patch | 1.01 KB | greggles |
Comments
Comment #1
gregglesComment #2
coltraneI'm in favor of this and will likely commit it as is.
But, while you raise this point I'm curious for your input on whether there's value in having variable names/IDs or configurable range of strengths? These values map into the ZxcvbnPhp library itself so changing the range would require a change there too.
Comment #3
coltrane(Edited to remove prior comment, it was actually about 2393873)
Comment #4
coltraneCommitted. Any bigger changes can go in a new issue.
Comment #6
gregglesI think there might be a desire by some people some day to have more granular control of the strengths, but that feels like a really low value thing that 90% of the module users don't want.