Comments

coltrane’s picture

Seems likely that these two can be RTBC and committed soon so I'd like to definitely wait for them.

* #2393873: Use current account rather than global $user in user_profile_form
* #2297471: Verify that passwords are matching on the frontend

While not required I'd also like to try and get in #2298875: Fix styling issues for password strength text

greggles’s picture

Great to know - thanks!

coltrane’s picture

Title: Create a beta and eventually a stable release » Create stable release
Issue summary: View changes
scor’s picture

For 6.x I'm going to have to create a new branch 6.x-2.x to avoid any confusion with the old project functionality.

@ben/@greggles, have you thought of also aligning 7.x, and switching to 7.x-2.x as well? in a sense, we're giving this namespace a second life, so I think this would make sense (and keep in sync with D6 too).

coltrane’s picture

I don't think there's a lot of confusion by having a 6.x-2.x and a 7.x-1.x so long as the documentation states that they're compatible and now that there is already a 7.x-1.x-beta1 I think moving it to a 2.x would create more confusion. @scor have you seen/heard of difficulties in projects having different minor branch identifiers cross major branch? I recall that confusion with Views but I think Password Strength is small enough to not have that.

scor’s picture

if we were to make that change/alignment, now would be the time with only a dozen install of password_strength beta1. I don't have any example to backup my claim, only common sense. What does greggles think?

greggles’s picture

I've heard passionate arguments in favor of using the same numbers for the same features across versions of core (what scor proposes) AND for renumbering down to 1 on every new major version of core. I mostly side with each new major version of core meaning a contrib goes back to 1. Given that 7.x-1.x already exists I think we should leave it as-is.

scor’s picture

cool, let's continue with 7.x-1.x and 6.x-2.x then...

greggles’s picture

Issue summary: View changes

What do you all think about this updated list before a full stable?

scor’s picture

Looks good. Just wish I had more time to contribute :( will do my best...

coltrane’s picture

Issue summary: View changes

updating summary

coltrane’s picture

Issue summary: View changes
mcdruid’s picture

Version: 7.x-1.x-dev » 8.x-2.x-dev

Apologies if this would be better as a new issue.

At the moment, the 7.x and 8.x recommended releases are both a long way behind:

$ drush rl password_strength
 Project            Release         Date         Status                 
 password_strength  8.x-2.x-dev     2016-Dec-05  Development            
 password_strength  8.x-2.0-alpha1  2015-Oct-20  Supported, Recommended

$ drush rl password_strength-7.x
 Project            Release        Date         Status                 
 password_strength  7.x-1.x-dev    2016-Oct-28  Development            
 password_strength  7.x-1.0-beta1  2014-Dec-20  Supported, Recommended

In particular, 8.x-2.0-alpha1 pre-dates #2633090: Remove dependency on Composer Manager, so projects which don't want to include the (deprecated) composer_manager module are forced to patch or use the dev version.

For a security-oriented module, it would ideal to have stable releases so that password_strength was covered by the security advisory policy.

Is there anything in particular holding back stable releases for the 7.x and 8.x branches (not sure if the original issue summary here is a little out-of-date)?

It would be good to tag new releases even if they're still alpha/beta/rc.

greggles’s picture

Here's the current release notes for the next release:

Changes since 7.x-1.0-beta1:

Seems like some good features for sure. I think a 7.x-1.0 should happen now and that the remaining issue (forcing minimum password strength) can be committed right after the 1.0 is released.

greggles’s picture

I made a 7.x-1.0 release and an 8.x-2.0-alpha2. I don't use 8.x so I don't feel super comfortable testing/reviewing/making releases. It seems OK to release at least a new alpha for 8.x so I did that.

@mcdruid - can you help review the open 8.x issues so they can get committed? In your opinion is the 8.x version ready for a "2.0" release?

mcdruid’s picture

Thanks @greggles, that's great.

I'll try to have a comb through the issue queue for 8.x

kekkis’s picture

What is the status of this module, is anyone at the helm currently? I agree with previous comments about the importance of security coverage.

greggles’s picture

Title: Create stable release » Create stable release of 8.x

Hi kekkis!

Thanks for your interest in the module. There are issues that need review. Will you review them?

greggles’s picture

Title: Create stable release of 8.x » Create stable release of 8.x-1.0

I filed #3196863: Create 8.x-2.0-beta2 stable release about the next 8.x-2 release

greggles’s picture

Title: Create stable release of 8.x-1.0 » Create stable release of 8.x-2.0

meep

john franklin’s picture

This module's latest release is over a year old and still a beta. Is there an ETA on when the full release can be cut?

greggles’s picture

Issue summary: View changes

There's only been one commit since 8.x-2.0-beta1, #2796239: Update Readme.txt to follow the readme template so I don't think a new release is quite warranted based on changes, but it is a good idea to get security team coverage.

It seems like there are some issues in the queue that would be good to fix prior to 8.x-2.0:

Can you help to test and review those?

greggles’s picture

OK, #3131663: Update t() calls to use $this->t() instead is the last one that should be fixed prior to 8.x-2.0.

Help testing would be great.

greggles’s picture

OK, on further reflection it seems there are 2 more that would be great to fix:

#3318807: Get automated tests passing
#2995816: Coding standard

joelpittet’s picture

#3320918: password_policy bumped to 4.x cross posting because I think it's a quick fix and likely needs to get in (or some variant of that MR) before a stable release.

greggles’s picture

I made https://www.drupal.org/project/password_strength/releases/8.x-2.0-beta2 today for that. Thanks, joelpittet.

Would be happy to make an 8.x-2.0 as soon as these 2 are done:

#3318807: Get automated tests passing
#2995816: Coding standard

I don't have time to spend on them personally so looking to get 2 people who will write the patches and review.

greggles’s picture

greggles’s picture