Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new6.72 KB
new10.05 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

deepakkm made their first commit to this issue’s fork.

Rajeshreeputra made their first commit to this issue’s fork.

vishalkhode’s picture

Issue summary: View changes
Status: Needs review » Needs work

Looks like there are couple of tests failures and deprecations and those needs to be fixed.

ankitv18 made their first commit to this issue’s fork.

chandu7929 changed the visibility of the branch project-update-bot-only to hidden.

chandu7929 changed the visibility of the branch project-update-bot-only to active.

deepakkm’s picture

created a new ticket to fix phpunit previous major issue on drupal 9 - https://www.drupal.org/project/password_policy/issues/3449074

vishalkhode’s picture

Status: Needs work » Reviewed & tested by the community

Reviewed changes and looks good to me.

project update bot’s picture

Version: 4.0.0 » 4.0.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new6.07 KB
new458 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-185727

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.1
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2

jrglasgow made their first commit to this issue’s fork.

jrglasgow’s picture

Issue summary: View changes

this is looking good to me

chandu7929 changed the visibility of the branch 3433859-automated-drupal-11 to active.

chandu7929 changed the visibility of the branch 3433859-automated-drupal-11 to hidden.

chandu7929 changed the visibility of the branch 3433859-automated-drupal-11 to active.

chandu7929 changed the visibility of the branch project-update-bot-only to hidden.

deepakkm’s picture

MR !84 is now ready for review, as all the work done in project update bot was removed we have cherry-picked all commit from that branch and added in the new branch.

vipin.mittal18 changed the visibility of the branch 3433859-automated-drupal-11 to hidden.

vipin.mittal18 changed the visibility of the branch 3433859-automated-drupal-11 to active.

deepakkm’s picture

vipin.mittal18’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new92.12 KB

There is warnings

Warning: Undefined array key "character_length" in Drupal\password_policy_length\Plugin\PasswordConstraint\PasswordLength->validateConfigurationForm() (line 130 of /home/ide/project/docroot/modules/contrib/password_policy/password_policy_length/src/Plugin/PasswordConstraint/PasswordLength.php)

on saving "character length" password constraint but can be ignored for this ticket as restriction works perfectly.
password policy character length validation

kristen pol’s picture

Status: Reviewed & tested by the community » Needs work

Thanks for testing. If there are warnings, they should be fixed first please. Moving back to needs work.

vipin.mittal18’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new149.01 KB

Hello Kristen,

How are you doing?

Despite my best efforts, I was unable to reproduce the issue again, even after a fresh installation with Drupal 11.0.0-rc1. This issue appears not to exist, as my colleagues also tried to replicate it. Therefore, I believe we can release a Drupal 11 compatible stable version of password policy. Apologies for any disruption.

An animated GIF is created as a reference to indicate that there are no more warnings being logged
Password policy password length constraint

vipin.mittal18’s picture

StatusFileSize
new15.38 MB
new1.31 MB
kristen pol’s picture

Thanks for retesting and providing more information. I probably won’t be able to look at this until next Tuesday or Wednesday. Feel free to ping me after that if I haven’t responded by Thursday next week.

andypost’s picture

+1 to get in and create new release

kristen pol’s picture

Thanks for the nudge… heads down on Starshot stuff for another couple days unfortunately. But maybe another maintainer has cycles. I’ll revisit later this week once I’m not under water.

Rajeshreeputra changed the visibility of the branch 3433859-automated-drupal-11 to hidden.

vishalkhode’s picture

Status: Reviewed & tested by the community » Needs work

Reviewed changes and looks good to me. However, looks like there are some un-related changes made to fix PHPCS & PHPStan etc. We can fix those in a separate ticket and limit the changes to Drupal 11 compatibility only.

rajeshreeputra’s picture

Status: Needs work » Needs review

Created MR!88 with the only required changes for Drupal 11 compatibility.

ankitv18’s picture

Status: Needs review » Needs work

Reviewed and provided some suggestions.

Also tests are failing which needs to be fixed, see: https://git.drupalcode.org/issue/password_policy-3433859/-/jobs/2274918#L65

ankitv18’s picture

Status: Needs work » Needs review

Address the changes.

vishalkhode’s picture

Status: Needs review » Needs work
ankitv18’s picture

Status: Needs work » Needs review

Reverted the changes of PasswordResetBehaviorsTest files ~~ pipelines are passing.

vishalkhode’s picture

Status: Needs review » Fixed

Reviewed changes and looks good to me.
@vipin.mittal18 The warning you mentioned above was not due to changes made on this ticket and have been addressed separately as part of #3452575: [4.0.1 regression] password_length constraint should check plugin id in validateConfigurationForm(). Hence, merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.