Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new7.19 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0

Status: Needs review » Needs work

The last submitted patch, 2: password_policy.3.x-dev.rector.patch, failed testing. View results

nkoporec made their first commit to this issue’s fork.

nkoporec’s picture

Issue summary: View changes
Status: Needs work » Needs review
project update bot’s picture

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1

Status: Needs review » Needs work

The last submitted patch, 7: password_policy.3.x-dev.rector.patch, failed testing. View results

nkoporec’s picture

Status: Needs work » Needs review

jcnventura made their first commit to this issue’s fork.

jcnventura’s picture

Issue tags: -ProjectUpdateBotD10

Removing the ProjectUpdateBotD10 since it seems clear that the rector changes are actually breaking the tests.

As per https://www.drupal.org/node/3070687#test, modules in the testing package should not specify any core_version_requirement at all.

jcnventura’s picture

Seems like some other people are wondering why rector does this replacement: #3300685: Unclear replacement of getMockBuilder() with createMock().

ameymudras’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new352.52 KB
new202.56 KB
new79.29 KB

Tested on Drupal 10.0.x and php 8.1

- Was able to install the module
- Was able to configure the password policy,
- Added a new policy and then forced password reset
- Upgrade status doesn't show any issues
- No issues / warnings in the Db log
- Did a code review and no other changes required

Looks RTBC to me

paulocs made their first commit to this issue’s fork.

paulocs’s picture

I have created a new 4.x branch and changed the target MR branch.

paulocs’s picture

Status: Reviewed & tested by the community » Fixed

I had to marge it locally and push the changes to 4.x branch because GitLab notified the branch did not exist even though I was able to set the right target branch.

https://git.drupalcode.org/project/password_policy/-/tree/4.x

I'll create a release soon. Thank you!

jcnventura’s picture

Thanks!

You might want to close the MR manually then: https://git.drupalcode.org/project/password_policy/-/merge_requests/39

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.