Add validation for expiration warning

Thanks for the bug report and patch. This issue actually applies to 7.x-1.x, not 7.x-2.x.

This problem is due to an invalid value being entered for the "Password Expiration Warning" field in the Password Policy configuration.

The validation code needs some improvement to disallow more or all invalid values:

  if (!empty($form_state['values']['warning']) && !preg_match('/^[0-9,]+$/', $form_state['values']['warning'])) {
    form_set_error('warning', t('Warning must only contain digits and commas.'));
  }

That regular expression would allow ,,,,, for example, which is invalid.

It would be better to fix it by disallowing invalid values instead of trying to cope with them by casting to int. I will attempt to improve the validation and share a patch. Thanks again for your bug report.

Really strange to me that that patch doesn't apply in testing.

immoreel, this bug is actually fixed in 7.x-1.x-dev since August: #2895670: Errors re invalid number on PHP7+. I think you must actually be using 7.x-1.14.

The bug as reported is already fixed. Changing title of issue to reflect attempt to add validation for the field, to prevent some possible invalid values.

Tests are now passing thanks to a fix on the drupal.org end.

I don't know why it just now submitted #2 for testing. #7 is the relevant patch here.