Any logged in user is constantly forwarded to the user edit for and is requested to change their password. Even after a password change the forwarding still persists and the system is treading the password as expired.

We tested with '0' as valid password time in the password policy rule and we set the 'last updated date' manually to a date from the future. Both did not helped.

CommentFileSizeAuthor
#14 2863169-password-expire-check-does-not-work-14.patch3.46 KBvoleger
#11 2863169-password-expire-check-does-not-work-11.patch3.42 KBgargsuchi
#10 2863169-password-expire-check-does-not-work-10.patch1.88 KBgargsuchi
#4 2863169-password-expire-check-does-not-work-2.patch767 bytesAshutosh Tiwari
#2 2863169-password-expire-check-does-not-work-1.patch1.58 KBAshutosh Tiwari
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ashutosh Tiwari created an issue. See original summary.

Ashutosh Tiwari’s picture

Ashutosh Tiwari CreditAttribution: Ashutosh Tiwari as a volunteer and commented
FileSize
2863169-password-expire-check-does-not-work-1.patch1.58 KB

Hello All,

I have made few changes in .module file of the Password Policy. Now it seems it is working fine.
changes are as follows:-
on line number 297 changed 

$uid = $form_state->getValue('uid');  to $data = \Drupal\user\Entity\User::load(\Drupal::currentUser()->id());
  $uid= $data->get('uid')->value ;

as it was not able to get current user id.

On line number 304 and 319 changed date format to date('Y-m-d H:i:s');

Please review the patch, it is fine or not.

Thanks

Ashutosh Tiwari’s picture

Ashutosh Tiwari CreditAttribution: Ashutosh Tiwari as a volunteer and commented
Priority: Normal » Major
Ashutosh Tiwari’s picture

Ashutosh Tiwari CreditAttribution: Ashutosh Tiwari as a volunteer and commented
FileSize
2863169-password-expire-check-does-not-work-2.patch767 bytes

Hello All,

I am sorry but previous patch will not work. I am uploading a new patch , Please try to review that. It is working fine for me. I just made changes in form submit action.

Thanks

Ashutosh Tiwari’s picture

Ashutosh Tiwari CreditAttribution: Ashutosh Tiwari as a volunteer and commented
Status: Active » Needs review

The last submitted patch, 2: 2863169-password-expire-check-does-not-work-1.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: 2863169-password-expire-check-does-not-work-2.patch, failed testing. View results

imen ch’s picture

imen ch CreditAttribution: imen ch commented

I have the same problem with Password Policy module on version 8.x-3.0-alpha4.
Did you resolved this problem ?

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented

I was able to reproduce this error on 8.x-3.x branch. attaching a patch for the same.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
FileSize
2863169-password-expire-check-does-not-work-10.patch1.88 KB
gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
FileSize
2863169-password-expire-check-does-not-work-11.patch3.42 KB

Above patch was failing tests (though none of my changes affected it). Fixed in the new patch hopefully.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and at Hook 42 commented

Requeue'd the tests

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and at Hook 42 commented

The patch in #11 needs re-rolled, but I'm not comfortable merging it in at the moment. The patch posted in #1 is a much smaller change and would seem to be in line with my understanding of the bug.

I'm not really keen on the patch posted in #11.

First, it looks like it proposes a switch from a date format to a time stamp, which would cause existing data to be broken. There is no update hook in place to convert. I may be wrong on this -- if I am, please let me know. The patch in #1 shows a potential fix that doesn't drastically change the data in the field. We still may need an update hook that converts the old values.

Second, the automated tests are now posting a "drupalGet" to make the tests pass. The point of the tests is to ensure the user is redirected. This actually bypasses the check for the test.

I'm moving this back to "needs work"

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at Lemberg Solutions, Drupal Ukraine Community for Drupal Ukraine Community, Lemberg Solutions commented
Status: Needs work » Needs review
FileSize
2863169-password-expire-check-does-not-work-14.patch3.46 KB

rerolled patch

Status: Needs review » Needs work

The last submitted patch, 14: 2863169-password-expire-check-does-not-work-14.patch, failed testing. View results

daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
Status: Needs work » Fixed

I did a bit of testing and found that this was fixed in #2852312: Password expiration not set to false on update, and has already been committed.

#4 in this issue mentioned this same solution of changing order of the submit callbacks on the form. In my tests I changed the callback order to the way they were previous to this issue being created (using array_unshift()) and that cause the redirects to continually happen. With the password policy submit callback appended to the end of the array, everything works as expected.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.