This submodule does not really apply to password "policies" at all. It's essentially just some menu and form trickery that best belongs as an entirely separate module.

Comments

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented

See https://drupal.org/project/password_tab

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrfelton’s picture

mrfelton CreditAttribution: mrfelton commented
Status: Closed (fixed) » Active

Until you commit some code to the password_tab module, this is not really fixed.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Active » Fixed

Initial port is started - #1923128: Port code from Password Policy module

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

roball’s picture

roball CreditAttribution: roball commented
Version: 7.x-2.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Active

I would suggest to also move the password_policy_password_tab module bundled with 6.x-1.x of password_policy away to it's own project. I have been using it for several years, but recently a the critical bug #1188264: Unable to (re)set password when "Password change tab" module is enabled unveiled with its latest "stable" release (6.x-1.5). It just has too much potential to introduce danger. It also does not play nice with password_policy at all. Having two branches of the same module split out into two separated projects would also harden harmonized development.

I personally will no longer use it, and if it stays in password_policy 6.x-1.x, I have to remove its directory from the "all/modules" shared directory of my multi-site environment, so people will not be able to enable a dangerous module.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Closed (fixed)

Because the module is already included in existing 6.x-1.x installations. It seems dangerous to just remove it without the implied notice of a branch upgrade. Let's focus our energy on resolving that critical issue.

roball’s picture

roball CreditAttribution: roball commented
Status: Closed (fixed) » Active

IMO, it would be best to just do the same to the D6 version of the module what already happened to the D7 version: Create a 6.x-2.x branch of password_policy without including password_policy_password_tab, and create password_tab 6.x-1.x at its own project.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Active » Postponed

Let's fix the critical first, then come back to this. Creating a 2nd 6.x branch will make any fixes take more time, which I'd rather focus on 7.x-2.x

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.