Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/paragraphs_tabs_bootstrap/paragraphs_tabs_bootstrap.info.yml
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/paragraphs_tabs_bootstrap/paragraphs_tabs_bootstrap.module
----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
20 | ERROR | [x] Short array syntax must be used to define arrays
33 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/paragraphs_tabs_bootstrap/src/Form/AddComponentForm.php
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
161 | WARNING | Unused variable $is_ajax.
-------------------------------------------------------------------------------------------

Time: 2.29 secs; Memory: 8MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/paragraphs_tabs_bootstrap/

Proposed resolution

Above error/warnings need to be fixed.

CommentFileSizeAuthor
#5 after_patch.png40.74 KBsahil.goyal
#2 3349797-2.patch2.1 KBsamitk

Issue fork paragraphs_tabs_bootstrap-3349797

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3349797-2.patch2.1 KB

Above errors/warnings has been fixed.

sahil.goyal made their first commit to this issue’s fork.

sahil.goyal opened merge request !1

sahil.goyal’s picture

sahil.goyal commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after_patch.png40.74 KB

Thanx @samit.310@gmail.com, Reviewed #2 applies cleanly fixed all the issues and warnings, Created MR for Easy merging. Moving to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Issue tags: -Coding standards Phpcs, -Phpcs Drupal coding standard issue
lazzyvn’s picture

lazzyvn commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.