Problem/Motivation

After updating the module to the current version, the function is broken. Both administrators and authenticated users have no more buttons.

The following errors are thrown in the dev console, see screenshot.

Steps to reproduce

  1. update module to 1.15, cache clear
  2. call a node with paragraphs or nested paragraphs
  3. no buttons are displayed anymore

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 Screen Shot 2022-02-02 at 4.17.21 PM.png20.56 KBapmsooner
Xnip2022-01-14_21-19-33.png280.75 KBzcht

Issue fork paragraphs_ee-3258673

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zcht created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Project: Paragraphs Features » Paragraphs Editor Enhancements
Version: 8.x-1.15 » 8.x-1.x-dev

Paragrapghs features has now it's own quick links functionality. This needs to be fixed in paragraphs ee

stBorchert made their first commit to this issue’s fork.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Title: Update to 1.15 breaks the function of the module » Changes introduced in Paragraphs Features 1.13 breaks everything

Paragraphs Features introduced the quick links in version 1.13 by copying main parts/concepts of Paragraphs Features. This results in breaking everything here.
I asked for a patch upfront but that didn't happen ...

stBorchert opened merge request !5

  • stBorchert committed afc4147 on 8.x-1.x 
    #3258673: rebuild after update of Paragraphs Features
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Active » Needs review

I've rewritten lots of code to make Paragraphs Editor Enhancements work again after the changes introduced in Paragraphs Features 1.13 and committed the changes to develop. A full release will follow soon.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Version: 8.x-1.x-dev » 2.0.0

I've decided to create a new major release so all changes made for the compatibility are now in version 2.0.0.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Version: 2.0.0 » 2.0.x-dev
apmsooner’s picture

apmsooner commented
StatusFileSize
new Screen Shot 2022-02-02 at 4.17.21 PM.png20.56 KB

I just updated to 2.0.0 and similar problem as described still exists although the buttons are there, they are unstyled and non-functioning.

Attached screenshot to show what i'm seeing. The form display settings are set to use modal form as add mode.

apmsooner’s picture

apmsooner commented
Status: Needs review » Needs work
stborchert’s picture

stborchert
he/him
Primary language German
commented

Thanks for the feedback.
Minutes after releasing 2.0.0 I updated the code so the module won't do its magic if "Add in between" hasn't been enabled. I saw that the dialog contents are displayed below the button (as in your screenshot) and hid them.
That seemed like a good idea a few hours ago but now I see that the dialog should still be pretty if do not you use "add in between" ... hm.

Stay tuned, I will post an update soon.

  • 0fc7f66 committed on 2.0.x 
    #3258673: fix automatic hiding of add-in-between buttons

Signed-off-by...
  • a85bb51 committed on 2.0.x
    #3258673: fix enhanced dialog for default modal button

Signed-off-by:...
  • cde0bd8 committed on 2.0.x
    #3258673: hide dialog contents if add-in-between is disabled

Signed-off...
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs work » Needs review

Please test using the latest development version (either using composer require 'drupal/paragraphs_ee:2.0.x-dev@dev' or download the release directly).

  • 3345544 committed on 2.0.x 
    #3258673: fix update-hook to move configuration to paragraphs_features...
apmsooner’s picture

apmsooner commented

@stBorchert - I've tested that dev version and confirm its all working good now. Thanks!

apmsooner’s picture

apmsooner commented
Status: Needs review » Reviewed & tested by the community
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Great to hear. Meanwhile I've create a new release so you can simply use version 2.0.1 :)

apmsooner’s picture

apmsooner commented

I noticed that but the default version seems to still be referencing 2.0: https://www.drupal.org/project/paragraphs_ee/releases/2.0.1

stborchert’s picture

stborchert
he/him
Primary language German
commented

You mean the composer command? Nope, that gets everything >=2.0 which is (for now) 2.0.1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.