In the upcoming version of the core (noticed in 11.4.0-rc1) the class .js-hide has been reworked.

Issue: https://www.drupal.org/project/drupal/issues/3514748

Commit: refactor: #3514748 Remove legacy browser support from js.module.css (https://git.drupalcode.org/project/drupal/-/commit/b7156dd5535584455fd3b...)

Currently, the !important being used in this rework seems to hide the paragraphs-add-dialog when it usually should be displayed.

CommentFileSizeAuthor
#8 Modal_after_fix.png87.57 KBstyx1983

Issue fork paragraphs-3596839

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

styx1983 created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Priority: Normal » Critical

I can confirm this is a problem on 11.4.x and that #3514748: Remove legacy browser support from js.module.css is the cause of the regression. @styx1983 great find.

alexpott opened merge request !260

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

The MR I've just pushed up fixes things for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Priority: Critical » Major

Hopefully #3514748: Remove legacy browser support from js.module.css will be reverted from 11.x but the change is still going to through on main aka 12.x so we need to apply the MR here. Fortunately the MR is BC compatible and semantically correct :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Note that we have test coverage that is broken on 11.4.x by the core change - see \Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsAddWidgetTest::testAddWidgetButton() so I think this work is complete.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me

styx1983’s picture

styx1983 commented
StatusFileSize
new Modal_after_fix.png87.57 KB

Thank you for the quick response @alexpott.

Unfortunately I have to disagree. The change fixes the modal, but the content of the modal is additionally shown in the background.

Then, when I close the modal using the (X), the content of the modal still is shown.

I'll attach a screenshot of what I meant. Sorry for the German language in it.

Modal with fix

styx1983’s picture

styx1983 commented
Status: Reviewed & tested by the community » Needs work

I'll change it back to "Needs work" for now and will try to tinker with it a little tomorrow.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@styx1983 I thought I looked for that - great spot. Thinking how to fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

Turned out to be really simple to fix ... just need to move the code to after the clone and everything is great.

styx1983’s picture

styx1983 commented
Status: Needs review » Reviewed & tested by the community

Nice, seems to work fine.

berdir made their first commit to this issue’s fork.

  • berdir committed 0c7b9830 on 8.x-1.x authored by alexpott 
    fix: #3596839 Refactoring of js.module.css in core forcefully hides...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.