#3111075: Use small button component for Claro introduced the 'small' button type for paragraph buttons. However, for modal actions a small button is not appropriate since the buttons are now the primary actions.
Use small button by default, but not for modal add mode.
Paragraph add buttons in the 'Modal' add mode no longer use small buttons.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | After_Patch.PNG | 16.43 KB | gaurav-mathur |
| #4 | Before_Patch.PNG | 17.41 KB | gaurav-mathur |
| #2 | 3262432-2.patch | 2.19 KB | idebr |
| #2 | 3262432-2-after.png | 104.42 KB | idebr |
| #2 | 3262432-2-before.png | 101.39 KB | idebr |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
idebr commentedAttached changes the appearance of paragraph buttons: Use small button by default, but not for modal add mode.
Before:
After:
Comment #3
gaurav-mathur commentedComment #4
gaurav-mathur commentedPatch #2 applied successfully on on Drupal 10.0.x-dev and PHP 8.1.6.
The patch work properly for me.
Refer to screenshots.
Comment #6
yashaswi18 commentedHi, just wanted to check - is this MR still needed as this is an old issue? Looking at the changes, it removes
button--smallfrom the default attributes inParagraphsWidget.phpand conditionally adds it back only when$add_mode !== 'modal', along with the corresponding CSS selector update from.button.button--smallto.buttoninparagraphs.modal.css. The code changes look good as both changes are consistent with each other.Has this already been addressed elsewhere in the codebase, or is this still the right approach? Please confirm.