When having Claro for Admin theme my required field didn't display required-mark (missing class required-mark)

Proposing a patch for this.

CommentFileSizeAuthor
#13 Screenshot 2026-03-27 at 11.09.55.png228.4 KBp-neyens
#13 Screenshot 2026-03-27 at 11.15.40.png232.01 KBp-neyens
#13 Screenshot 2026-03-27 at 11.10.29.png158.66 KBp-neyens
#12 required mark.png43.96 KBdeepalij
#10 paragraphs-n3153915-10.patch1.4 KBdamienmckenna
#9 paragraphs-required-patch-against-1.12-do-not-use-153915-9.patch1.37 KBdouggreen
#5 INTERDIFF.txt857 bytesmaxpah
#5 3153915-5.patch1.38 KBmaxpah
#2 3153915-2.patch588 bytesmaxpah

Comments

MaxPah created an issue. See original summary.

maxpah’s picture

maxpah
Primary language French
commented
StatusFileSize
new 3153915-2.patch588 bytes
maxpah’s picture

maxpah
Primary language French
commented
Assigned: maxpah » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3153915-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

maxpah’s picture

maxpah
Primary language French
commented
StatusFileSize
new 3153915-5.patch1.38 KB
new INTERDIFF.txt857 bytes
maxpah’s picture

maxpah
Primary language French
commented
Status: Needs work » Needs review
sasanikolic’s picture

sasanikolic commented

@MaxPah I think that .form-required class is enough also for Claro. I see the required mark when using only that class and I see the .form-item__label.form-required::after, .fieldset__label.form-required::after in claro/css/components/form.css.

douggreen’s picture

douggreen commented
Version: 8.x-1.12 » 8.x-1.x-dev

The patch applies cleanly against 8.x-1.x-dev, but not against 8.12, so I changed the version.

douggreen’s picture

douggreen commented
StatusFileSize
new paragraphs-required-patch-against-1.12-do-not-use-153915-9.patch1.37 KB

I've uploaded a new patch that applies cleanly against the latest tagged version, merely so that my site can use a stable release, and still cleanly apply this patch. The only difference is that the test was moved from Functional/Classic to Functional/WidgetLegacy.

To be abundantly clear, we should merge the previous patch, not this one.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new paragraphs-n3153915-10.patch1.4 KB

This is a reroll of #5 and contains no other changes.

deepalij’s picture

deepalij commented

Not able to reproduce this issue, as I can see the required mark on the required field
Checking on Drupal 10.1.x-dev claro theme with Paragraphs version 8.x-1.x-dev

deepalij’s picture

deepalij commented
StatusFileSize
new required mark.png43.96 KB
p-neyens’s picture

p-neyens commented
StatusFileSize
new Screenshot 2026-03-27 at 11.10.29.png158.66 KB
new Screenshot 2026-03-27 at 11.15.40.png232.01 KB
new Screenshot 2026-03-27 at 11.09.55.png228.4 KB

I can confirm that the issue is still there.

strong no asteriks

paragraph 1.17 => IN 1.20 the code is the same https://git.drupalcode.org/project/paragraphs/-/blob/8.x-1.20/src/Plugin...

When i apply the patch i get the asteriks.

past asteriks

But why do we nog change the type for the title element to label then we don't need to add a additional class?

Label instead strong