Problem/Motivation

Build is failing: https://www.drupal.org/pift-ci-job/680269

Proposed resolution

Remaining tasks

Determine cause.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 build_failing_schema-2881459-7.patch508 bytesPrimsi
#2 2881459-2.patch588 bytespenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2881459-2.patch588 bytes

Not entirely sure this is the right fix, but makes the test pass.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I don't see how that is different from the parent definition:

mapping:
target_bundles:
type: sequence
label: 'types'
nullable: true
sequence:
type: string
label: 'Type

We should inherit that?

Will have a look at this.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Ah, because the parent was changed, we should extend from entity_reference_selection.default now.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

This was caused by #2787873: Add a base class for entity reference selection handlers and fix the structure of their configuration, I commented there to indicate that this was a BC break.

Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Assigned: Unassigned » Primsi
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
build_failing_schema-2881459-7.patch508 bytes

So we want it like that?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

I'd expect tests on 8.4 to pass and tests on 8.3 to fail, which is a problem as it's not just test.

It's possible that the first patch would pass on both 8.4 and and 8.3, that might be an argument to commit that and keeping this issue open until 8.4 is out, then we could do it correctly, without worrying about 8.3 anymore.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Needs review
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Passes on 8.3 too, then lets commit this.

  • Primsi committed 721372a on 8.x-1.x 
    Issue #2881459 by penyaskito, Primsi, Berdir: Build failing: Schema...
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented

Thanks a lot for the quickness!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.