Paragraph with no translation enabled gets broken [#2761493]

Problem/Motivation

When we enable translation for a content type with a not translatable (no translation enabled) paragraphs field, we create a node and attempt to translate it, we get a error like:

Field content_translation_source is unknown.

Proposed resolution

Fix it.
Write tests.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#9	paragraph_with_no-2761493-9.patch	4.2 KB	johnchque
#9	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 43 pass PHP 5.6 & MySQL 5.5, D8.2 43 pass PHP 7 & MySQL 5.5, D8.2 43 pass
#9	interdiff-2761493-4-9.txt	1.56 KB	johnchque
#9	paragraph_with_no-2761493-9-test-only.patch	2.15 KB	johnchque
#9	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 7 & MySQL 5.5, D8.2 42 pass, 2 fail
#4	paragraph_with_no-2761493-4.patch	4.21 KB	johnchque
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 43 pass PHP 5.6 & MySQL 5.5, D8.2 43 pass PHP 7 & MySQL 5.5, D8.2 43 pass
#4	paragraph_with_no-2761493-4-test-only.patch	2.15 KB	johnchque
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 7 & MySQL 5.5, D8.2 42 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

6 July 2016 at 14:11

yongt9412 created an issue. See original summary.

Comment #2

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker at MD Systems GmbH commented 13 July 2016 at 13:08

Issue tags:

+Needs tests

I don't get the description...
It sounds like i would always trigger this condition when doing multilingual setup?

Step by step please...
(A test? And a fix? ;-) )

Comment #3

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 13 July 2016 at 15:20

Issue summary:

View changes

Comment #4

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 13 July 2016 at 15:23

Status:

Active

» Needs review

File	Size
paragraph_with_no-2761493-4-test-only.patch	2.15 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 7 & MySQL 5.5, D8.2 42 pass, 2 fail
paragraph_with_no-2761493-4.patch	4.21 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 43 pass PHP 5.6 & MySQL 5.5, D8.2 43 pass PHP 7 & MySQL 5.5, D8.2 43 pass

Discussed with @Berdir this fix should be enough, the paragraph that is displayed on translation is the one available for all languages. :)

Comment #5

13 July 2016 at 15:26

The last submitted patch, 4: paragraph_with_no-2761493-4-test-only.patch, failed testing.

Comment #6

13 July 2016 at 15:27

The last submitted patch, 4: paragraph_with_no-2761493-4-test-only.patch, failed testing.

Comment #7

13 July 2016 at 15:27

The last submitted patch, 4: paragraph_with_no-2761493-4-test-only.patch, failed testing.

Comment #8

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 13 July 2016 at 20:47

Status:

Needs review

» Needs work

+++ b/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
@@ -240,14 +240,21 @@ class InlineParagraphsWidget extends WidgetBase {
+        // If translation is not enabled for paragraphs field do not switch.
+        if ($paragraphs_entity->hasField('content_translation_source')) {
+          // Switch the paragraph to the translation.
+          $paragraphs_entity = $paragraphs_entity->getTranslation($langcode);
         }

The comment isn't correct, that's not what it is doing.

The source field is a base field. It is added if at least one paragraph type is translatable. But it existing doesn't mean that the paragraph type that you have is actually translatable. And it's even less about the paragraph field.

As quickly discussed, the question is, what should we do if the paragraph type is indeed not translatable? Maybe not show the paragraph at all. Or show a message that paragraph type X is not translatable? I'm not sure..

I'd also be ok with saying we just prevent the error for now and figure that out later. But then we need a better comment and I think we should have a single wrapping if() around the whole multilingual thingies. And maybe an "All languages" suffix on the label, like core has for shared fields?

Comment #9

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 14 July 2016 at 10:12

Status:

Needs work

» Needs review

File	Size
paragraph_with_no-2761493-9-test-only.patch	2.15 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.2 42 pass, 2 fail PHP 7 & MySQL 5.5, D8.2 42 pass, 2 fail
interdiff-2761493-4-9.txt	1.56 KB
paragraph_with_no-2761493-9.patch	4.2 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 43 pass PHP 5.6 & MySQL 5.5, D8.2 43 pass PHP 7 & MySQL 5.5, D8.2 43 pass

Manually testing, when a paragraph is not translatable it is always displayed with a (all languages), actually IMHO it makes sense to displayed and the if added works fine in that way.

Comment #10

14 July 2016 at 10:15

The last submitted patch, 9: paragraph_with_no-2761493-9-test-only.patch, failed testing.

Comment #11

14 July 2016 at 10:16

The last submitted patch, 9: paragraph_with_no-2761493-9-test-only.patch, failed testing.

Comment #12

14 July 2016 at 10:16

The last submitted patch, 9: paragraph_with_no-2761493-9-test-only.patch, failed testing.

Comment #13

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker at MD Systems GmbH commented 15 July 2016 at 22:22

Status:	Needs review	» Needs work
Issue tags:	-Needs tests

Improved some comments and committed. :-)

Still back to needs work to create follow-ups about the workflow in the situation. We need to decide what experience is the goal.

Comment #14

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker at MD Systems GmbH commented 20 July 2016 at 09:33

Sry, accidentally committed with reference and message to #2755897: Cannot use paragraphs within Contact form

Comment #15

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 6 February 2018 at 21:59

Status:

Needs work

» Fixed

I have a feeling those follow-ups aren't going to be created if it didn't happen in the last two years and we likely fixed the problems we identified or there are open issues about it.