Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We currently have no tests for inline editing functionality.
Proposed resolution
Provide test coverage.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#3 | test_coverage_for-2429271-3-interdiff.txt | 11.41 KB | sasanikolic |
#3 | test_coverage_for-2429271-3.patch | 10.27 KB | sasanikolic |
#1 | test_coverage_for-2429271-1.patch | 8.33 KB | sasanikolic |
Comments
Comment #1
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedAdded the test for inline editing.
Probably would be good to separate this test in a new method?
Comment #2
miro_dietikerWhy would you want to do this conditionally?
In any case, if you really need to stop a test, use the return statement conditionally. Always avoid valueless indentation.
Finally the test method is getting crazily long... If not now, then we really need a followup to split the method.
Comment #3
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedSeparated the test into a new method here.
The conditional was from the QuickEditLoadingTest (quickedit core test). I have removed it in this patch.
Also, changed the misspelling from 'TEST TITEL' to 'TEST TITLE'.
Comment #4
miro_dietikerBig chunks really look like a test that tests the core quickedit functionality in step details.
We depend on this test. We trust core does it right. We don't need to repeat the internals. If you want, just add a reference with @see.
I think we only should check that Paragraphs inline changes are stored properly and output.
The problem with this test in general is that it is not driven by a JS browser. Much more it tests what a JS aware client would execute. There's still a lot of room for things to break.
Comment #5
miro_dietikerWhat i just realised is that inline editing is subject to change anyway in Paragraphs...
I think we should postpone this test until #2476863: [META] Integrate more nicely with quick edit