At the risk of repeating myself:

Totally minor, removes the need for this patch that is present in panopoly_admin.

We have a platform built on top of Panopoly, and are trying to keep all modules as current as possible, so creating this issue…

CommentFileSizeAuthor
#12 panopoly_admin-breakpoints-16-2936050-12.patch551 bytesdsnopek
#2 panopoly_admin-update_breakpoints_module-2936050-2.patch710 bytesbyronveale
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

byronveale created an issue. See original summary.

byronveale’s picture

byronveale CreditAttribution: byronveale at Princeton University commented
FileSize
panopoly_admin-update_breakpoints_module-2936050-2.patch710 bytes

…and uploading this patch (attached).

byronveale’s picture

byronveale CreditAttribution: byronveale at Princeton University commented
Status: Active » Needs review
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne at Princeton University commented
Status: Needs review » Reviewed & tested by the community

We've had this in prod for weeks w/o issue.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Thanks! Here's a test build:

https://travis-ci.org/panopoly/panopoly/builds/376077972

byronveale’s picture

byronveale CreditAttribution: byronveale at Princeton University commented

Repeating myself, but here's more low-hanging fruit…

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Test build had a "random failure" - re-running the first job to see if it passes the 2nd time. If it does, I'm inclined to commit this. It isn't as simple as the Apps changes - there's lots more in this release than just the patch we were using - but the changes seem pretty solid.

  • dsnopek committed 78027df on 7.x-1.x 
    Update Panopoly Admin for Issue #2936050 by byronveale, bkosborne:...
byronveale’s picture

byronveale CreditAttribution: byronveale at Princeton University commented

Ha-ha, apologies, I typed comment #6 without seeing your comment #5 (browser tab was open from earlier today)!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Title: Update Breakpoints module to 7.x-1.4 » Update Breakpoints module to 7.x-1.6
Status: Reviewed & tested by the community » Needs work

Ah, crap! I committed this, but then realized that the latest version 1.6 (which is the diff I was looking at) but we only updated to 1.4. :-( This will need another patch or getting all the way to 1.6

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
panopoly_admin-breakpoints-16-2936050-12.patch551 bytes

New patch attached!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/376196797

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs work » Needs review

  • dsnopek committed efdd807 on 7.x-1.x 
    Update Panopoly Admin for Issue #2936050 by byronveale, dsnopek,...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs review » Fixed

Tests are passing! Committed :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.