The 1.2 version of views_autocomplete_filters was just released:

https://www.drupal.org/node/2455803

It looks like bug fixes and new features.

I haven't done any testing yet, but the only place I think we use it is in the "Content item" widget.

CommentFileSizeAuthor
#12 panopoly_core-autocomplete-1.2-2456255-12.patch1.61 KBdsnopek
#10 panopoly_core-autocomplete-1.2-2456255-10.patch1.38 KBdsnopek
#2 panopoly_core-autocomplete-1.2-2456255-1.patch993 bytesdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Hrm. For some reason, views_autocomplete_filters isn't working for me at all on my local -dev site, for both the 1.1 version (what we have in Panopoly 1.21) and 1.2. But I spun up a site on Pantheon and it worked - so it must be some environment thing, but it's stopping me from manually testing this upgrade. :-/

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
panopoly_core-autocomplete-1.2-2456255-1.patch993 bytes

In any case, here's the patch for when I come back to this.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Gaggle.net, Inc. commented
Status: Needs review » Reviewed & tested by the community

Manual testing passed, as did running contentitem_widget.feature locally.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed :-)

  • dsnopek committed 463a48e on 7.x-1.x 
    Update Panopoly Core for Issue #2456255 by dsnopek: Update...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Fixed » Needs work

This is breaking update tests with:

require_once(/home/travis/build/panopoly/drupal/profiles/panopoly/modules/contrib/views_autocomplete_filters/views_autocomplete_filters_handler_filter_string.inc):[warning]
failed to open stream: No such file or directory bootstrap.inc:3186
PHP Fatal error:  require_once(): Failed opening required '/home/travis/build/panopoly/drupal/profiles/panopoly/modules/contrib/views_autocomplete_filters/views_autocomplete_filters_handler_filter_string.inc

Basically, the 'views_autocomplete_filters_handler_filter_string.inc' file has moved to another path. Doing drush rr would probably fix it, but since not everyone has that installed, I'd prefer to come up with a solution that doesn't require that.

For the time-being I'm reverting this change until we can figure out a solution!

  • dsnopek committed a862b94 on 7.x-1.x 
    Revert "Update Panopoly Core for Issue #2456255 by dsnopek: Update...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Gaggle.net, Inc. commented

Ah.. that is weird! I thought on updates it rebuilt module data, which should update the .info file's listings.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Parent issue: » #2530998: [meta] Get Panopoly 1.x into maintenance mode (so we can focus on Drupal 8)
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs work » Needs review
FileSize
panopoly_core-autocomplete-1.2-2456255-10.patch1.38 KB

Here's a simple attempt at an update hook to fix this! I'll run through Travis in a moment.

EDIT: Here is the Travis build: https://travis-ci.org/panopoly/panopoly/builds/71470592

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Seems to be working! I'm going to try another Travis build that runs ALL the upgrade tests before committing it for real:

https://travis-ci.org/dsnopek/panopoly/builds/71652547

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
panopoly_core-autocomplete-1.2-2456255-12.patch1.61 KB

Ok, looking at the last test build, it's upgrading from 1.14, 1.15, 1.16, 1.17 and 1.18 that fails. It appears its module_filter_update_7200() that's causing the trouble. So, the next thing to try is add a dependency on the new update hook. And here's a new patch to try that!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

The tests passed!

https://travis-ci.org/dsnopek/panopoly/builds/71665515

Next time I'm on my computer this should be ready to commit.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs review » Reviewed & tested by the community

RTBC'ING my own issue but only so I don't forget :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Reviewed & tested by the community » Fixed

Committed!

  • dsnopek committed 4ee5a6b on 7.x-1.x 
    Update Panopoly Widgets for Issue #2456255 by dsnopek, mglaman: Update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bgronek’s picture

bgronek CreditAttribution: bgronek commented

Now that this has been pushed through Pantheon, I am finding that this issue is causing my local development environment to fail with the following message:

Fatal error: require_once(): Failed opening required '/www/drupal/profiles/panopoly/modules/contrib/views_autocomplete_filters/views_autocomplete_filters_handler_filter_string.inc' (include_path='.:/usr/share/php:/usr/share/pear') in /www/drupal/includes/bootstrap.inc on line 3202

I tried drush rr as noted above and it only resulted in a repeat of the above error message.

Looks like there might be some more, and rather urgent, work to be done on this.

Thanks so much for your efforts!!!

bgronek’s picture

bgronek CreditAttribution: bgronek commented
Status: Closed (fixed) » Active

Based on the recent occurrence posted above, I would venture to say that this is not quite fixed.

bgronek’s picture

bgronek CreditAttribution: bgronek commented
Status: Active » Closed (fixed)

Switching back to fixed.

Apologies for the confusion.

Kids, be sure to run /update.php when you bring a new build down to your local environment ;)

Thanks for everything!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Whew! Glad you worked it out. :-)

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach as a volunteer and at Kalamuna commented
Related issues: +#2493069: Error due to moved include file

Fixing this in the module itself is at: #2493069: Error due to moved include file