When a user adds a custom region title, the title currently could not be created.
I will create a patch for this.

CommentFileSizeAuthor
#17 panels_tabs-title-2643800.patch1 KBchaitanya17
#14 panels_tabs-title-2643800.patch930 byteschaitanya17
#10 custom-region-title-not-translatable-2643800.patch897 bytesashwinsh
#7 custom-region-title-not-translatable-2643800.patch945 bytesashwinsh
#2 panel_tabs-custom-region-title-not-translatable-2643800-1.patch741 bytessgurlt

Comments

sg88 created an issue. See original summary.

sgurlt’s picture

sgurlt commented
Assigned: sgurlt » Unassigned
Status: Active » Needs review
StatusFileSize
new panel_tabs-custom-region-title-not-translatable-2643800-1.patch741 bytes

Please review.

Status: Needs review » Needs work

The last submitted patch, 2: panel_tabs-custom-region-title-not-translatable-2643800-1.patch, failed testing.

sgurlt’s picture

sgurlt commented

Can someone tell me why this fails?

TimRutherford’s picture

TimRutherford commented

I haven't checked out the full modules code but you can't/shouldn't use t() to translate just a variable. You can read about it more at https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/t/7

I'm assuming that is why its failing.

7thkey’s picture

7thkey commented

Do we have any solution for this or is it abandoned?

ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
commented
StatusFileSize
new custom-region-title-not-translatable-2643800.patch945 bytes

Can you please try this one.

ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: custom-region-title-not-translatable-2643800.patch, failed testing.

ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
commented
StatusFileSize
new custom-region-title-not-translatable-2643800.patch897 bytes
ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: custom-region-title-not-translatable-2643800.patch, failed testing.

7thkey’s picture

7thkey commented

@ashwin.shaharkar I tried and it works but the patch doesn't pass the test because like @TimRutherford said, you cannot use t() function to an input variable where user can enter whatever text with the risk of cross-site scripting...

There must be another way.

Any ideas?

chaitanya17’s picture

chaitanya17 commented
StatusFileSize
new panels_tabs-title-2643800.patch930 bytes

Translated text variable.

chaitanya17’s picture

chaitanya17 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: panels_tabs-title-2643800.patch, failed testing.

chaitanya17’s picture

chaitanya17 commented
StatusFileSize
new panels_tabs-title-2643800.patch1 KB