Content of placed title block does not show up [#2933423]

Problem/Motivation

When placing the title block it is not rendered.

This seems to be a common problem in panels space:
page_manager: #2626090: Page title block placed on block page renders empty
panels: #2869412: Page title does not display

Proposed resolution

Try fixing it by using the fix contained in #2858004-9: Use PE display variant on any path without route overrides.

Remaining tasks

~~Write test that verifies the bug.~~
~~Apply fix from #2858004-9: Use PE display variant on any path without route overrides~~
Compare solution with solutions in other issues

Comment	File	Size	Author
#9	panels_everywhere-n2933423-9.interdiff.txt	2.94 KB	DamienMcKenna
#9	panels_everywhere-n2933423-9.patch	5.51 KB	DamienMcKenna
#9	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.5 PHPLint Failed PHP 7 & MySQL 5.5, D8.5 PHPLint Failed
#8	panels_everywhere-n2933423-8.patch	5.12 KB	DamienMcKenna
#8	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass
#5	panels_everywhere--fix-title-block--2933423-2.testOnly.patch	3.18 KB	Alumei
#5	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 7 pass, 2 fail
#3	panels_everywhere--fix-title-block--2933423-2.testOnly.patch	5.32 KB	Alumei
#3	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass
#3	panels_everywhere--fix-title-block--2933423-2.patch	5.32 KB	Alumei
#3	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

28 December 2017 at 21:06

Alumei created an issue. See original summary.

Comment #2

Alumei CreditAttribution: Alumei commented 28 December 2017 at 21:23

Issue summary:	View changes
Related issues:		+#2626090: Page title block placed on block page renders empty, +#2869412: Page title does not display

Update summary with references to same problem in panels & page manager.

Comment #3

Alumei CreditAttribution: Alumei commented 28 December 2017 at 21:35

Issue summary:

View changes

File	Size
panels_everywhere--fix-title-block--2933423-2.patch	5.32 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass
panels_everywhere--fix-title-block--2933423-2.testOnly.patch	5.32 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass

Created patch with test only as well as one with the test included.

Comment #4

Alumei CreditAttribution: Alumei commented 28 December 2017 at 21:35

Status:

Active

» Needs review

Trigger tests.

File	Size
panels_everywhere--fix-title-block--2933423-2.testOnly.patch	3.18 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 7 pass, 2 fail

File	Size
panels_everywhere--fix-title-block--2933423-2.testOnly.patch	5.32 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass

Comment #6

28 December 2017 at 22:12

Status:

Needs review

» Needs work

The last submitted patch, 5: panels_everywhere--fix-title-block--2933423-2.testOnly.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 29 December 2017 at 03:27

Status:

Needs work

» Needs review

File	Size
panels_everywhere-n2933423-8.patch	5.12 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4.3 8 pass

File	Size
panels_everywhere-n2933423-9.patch	5.51 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.5 PHPLint Failed PHP 7 & MySQL 5.5, D8.5 PHPLint Failed
panels_everywhere-n2933423-9.interdiff.txt	2.94 KB

Comment #10

Alumei CreditAttribution: Alumei commented 17 February 2018 at 22:16

While working on #2869412: Page title does not display I realized that panels allows the title to be set statically inside the panel. It also allows for token replacement.
Now if I understand #2858004: Use PE display variant on any path without route overrides correctly that should allow token replacement to work as that replacement seems to rely on contextual information.
Such token replacement should normally have access to the page title see #2714257: [current-page:title] not working properly on pages with a render array as title.

As the current behavior does not take into consideration the configured panels page title but actually overrides it in PanelsEverywhereDisplayVariant:build(), ensuring that [current-page:title] in the panels title input contains the correct value seems to be the most reasonable.

I also had another idea, which was about providing a special placeholder like '<original>' which could be put into the panels title field.During rendering we could check the configured panels title and use the current behavior in case '<original>' was present and use the rendered configured title otherwise. In contrast that does seem as nice as the simple power of token replacement.