Using the default site_template and turning on node revisions, if I click the "View changes" button while editing a node, the change table is shown twice.

The diff module shows the changes by setting $form_state['node_preview'] which then gets placed into the $form['#prefix'] key for the entire page. This #prefix gets added to the entire panels_everywhere page, but also gets added when the actual page content is rendered within the page-content pane.

I've found a workaround that I'll post as a patch next

CommentFileSizeAuthor
#4 panels_everywhere-n2656312-4.patch940 bytesDamienMcKenna
#3 panels_everywhere-node-changes-shown-twice-2656312-3.patch727 bytesmpotter
#2 panels_everywhere-node-changes-shown-twice-2656312-2.patch667 bytesmpotter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpotter created an issue. See original summary.

mpotter’s picture

mpotter CreditAttribution: mpotter commented
FileSize
panels_everywhere-node-changes-shown-twice-2656312-2.patch667 bytes

Here is a patch that seems to fix it. Not sure if this has any other side-effects, but have tried other pages that use the $form['#prefix'] and they seem to still work.

mpotter’s picture

mpotter CreditAttribution: mpotter commented
FileSize
panels_everywhere-node-changes-shown-twice-2656312-3.patch727 bytes

Here is an update. On older PHP versions there was a problem if the $info['content'] was a string instead of array.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
panels_everywhere-n2656312-4.patch940 bytes

A minor adjustment. I'd prefer to add some additional checks to limit the display to node previews rather than just always remove the #prefix and #suffix.