Now that the testbots support running PHP 7 code, lets fix all PHP 7 bugs in Panels.

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2760041: Make CTools on D7 fully compatible with PHP 7
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Of course Panels doesn't have *any* tests, so that might be the first step.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: +PHP 7.0 (duplicate)
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Per https://www.drupal.org/pift-ci-job/355397 it seems the class constructors need to be rewritten.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

The class constructors have been fixed already, the module just needs a new release that includes them.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Postponed

Postponing this until CTools is fixed.

hass’s picture

hass CreditAttribution: hass commented

Why this? Less warnings do not depend on ctools

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

I postponed this because we won't get any positive results from testbot until CTools' tests pass.

hass’s picture

hass CreditAttribution: hass commented

Well, but I can install dev or next official version and than and get a lot less warnings on every page load. That does not need to wait for ctools tests.

dillix’s picture

dillix CreditAttribution: dillix commented
Status: Postponed » Active

I installed latest dev of ctools, but I've got these errors in panels:

PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; panels_cache_object has a deprecated constructor in /usr/home/site/site.dev/htdocs/sites/all/modules/panels/includes/plugins.inc on line 117
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; panels_allowed_layouts has a deprecated constructor in /usr/home/site/site.dev/htdocs/sites/all/modules/panels/includes/common.inc on line 44
MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Status: Active » Postponed

@dillix: Use the latest dev of Panels then, this was fixed in #2557061: deprecated constructor in PHP 7.

dillix’s picture

dillix CreditAttribution: dillix commented

May be its time to make new release before D 7.50 released?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Postponed » Active

Now that CTools 7.x-1.10 is out with the PHP 7 fixes, we can get back to work on this!

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

Are there Panels specific problems or the new release of CTools fixes everything?

TrevorBradley’s picture

TrevorBradley CreditAttribution: TrevorBradley commented

@maximpodorov: As best I can tell, the Panels problems were fixed in the dev version, and then an urgent security fix for Panels was deployed and the PHP7 compatibility came along with them.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Postponed

We'll know more when we start adding tests (#2808983: Add tests to Panels) and japerry enables automated testing.