Add a button for adding CSS id or CSS class for a region in IPE

Works great. Would perhaps look better if it was a graphic rather than the word 'style' to fit into the panels interface. Perhaps a hash tag icon to represent an ID.

Thank you though it's exactly what I was after. Very very useful.

Hello,

your patch is not ready to be ported, it broke my test installation.

home$ curl http://drupal.org/files/allow_styling_regions_panes_ipe-1549660-1_0.patch | git apply
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   629  100   629    0     0   1543      0 --:--:-- --:--:-- --:--:--  2676
<stdin>:9: trailing whitespace.
  
warning: 1 line adds whitespace errors.
home$ drush cc all

Fatal error: Call to undefined function conf_path() in /usr/lib/php/pear/drush/includes/bootstrap.inc on line 774
Drush command terminated abnormally due to an unrecoverable error.                                                                                    [error]
Error: Call to undefined function conf_path() in /usr/lib/php/pear/drush/includes/bootstrap.inc, line 774

As soon as I downloaded back a fresh panel module (without the patch) and cleared manually all my caches in the database, everything was back to normal.

FYI : Status settings for an issue

This patch will add a very nice option to panels.

Ah yes, wrong status caused this patch to never be seen.

sp-drupy: Your problem is more likely a bug in drush that I've run into from time to time. cd out of the panels directory and run your drush cc all from there.

The patch worked fine for me. The patch was applied against 3.3 version. Screenshot attached

What file have you applied the patch against? Apologies if this seems a daft question. It's to be applied against panels/panels_ipe/panels_ipe.module file. My patched working version is attached.

@Magic Man Merlin

Can we have this in the dev asap? Maybe needs a graphic rather than just the wording but, it's been invaluable to me already.

I applied the patch again, and no bug occurred.

But I don't see the buttons... (I did clear caches and updb)
Do you see them in the panel page variant content layout or directly in the website page while viewing the panel?

I applied the patch against 7.x-3.x-dev.

Thanks

Directly on the webpage. IPE editor has to be selected over standard panels when setting up the panel page. Once you click the black buttons on the bottom of the page and the panels pop up you should see the changes.

Thank you, I was not using ipe actually.

But the style box only appears in the panes themselves (mirroring an existing option) not in the regions panes.

See my image, the region panes are in blue, and the style box is missing.

I think I misunderstood the use case, and this is actually doing what it is supposed to do.
It adds a button to change the css of a pane in a region.

I was looking for something that would let me apply a css class to a whole region.
For example if ones wants to change the css class of ".rounded-corner" but just for a region it is not presently possible. You have to end changing the css class of all ".rounded-corner" in your website.

So +1 for this patch, I might write a feature request then ;)

Do we really need a separate button for this? It would seem to make more sense to merge these settings into the 'Region style' button that we already have (the paintbrush icon). I can't see that it makes much sense to provide two different places to go and edit style properties.

Yep I agree. It would be great to have this in the next version. I did wonder why there was a separate button. I second mrfelton's view so move the features in this patch into the existing settings paintbrush section.

Has anything been decided on this?

What about taking joel rotelli's patch and applying it so the class options are placed inside the paintbrush icon settings as suggested instead of a seperate button.

Then maybe this could be committed to core merlin?

It's a very useful feature to have and could do with being committed.

Man, I sure would like to see this happen. It would make it a lot easier to apply styling.

This would be invaluable, but if it goes in the style area, then it should be *in addition* to the other styles, not as a choice between different styles.

Bump.

@joel rotelli given it's your patch what do you think about mrfelton's suggestion on #11 to move this functionality into the region style button?

Maybe it would get committed to panels core merlin if this happened?

I think it'd be good to expose the text boxes in styles modal popup, but not replace a chosen style.

For what it is worth, found this in Panopoly: #2054095: Create Style Plugin for a Custom CSS Class. It adds a new button called "CSS." If the thought is to consolidate, this form within the styles modal would be fitting.

Marked #2054095: Create Style Plugin for a Custom CSS Class as a duplicate of this, but attaching @arshadcn's patch from that issue for reference as its a good starting point.

Here's a patch to Panels IPE based on #19. It adds a "CSS" button after the style button, if the user can administer the advanced pane settings (the same permission they need to edit CSS properties on the backend). There's no icon, but the text "CSS" doesn't look half-bad. I think we can use this as-is.

Patch in #20 does it for me :)

Patch #20 works for me too
Thx!

ehh. While the rest of the patch is good, w/o an image I don't think this passes for me. Different fonts and colors can make the css link look really bad. Lets get an image in here :)

Here is an updated patch with an image

Here is how the image button looks.

Okay, this looks good now. Thanks! Committed.

FYI, /panels_ipe/css/panels_ipe.css is looking for this new icon-css.png in /panels_ipe/images, but in the 7.x-3.9 release this file was added to /images. We probably need to move this file to /panels_ipe/images, or update the CSS reference.

// panels_ipe/css/panels_ipe.css
div.panels-ipe-handlebar-wrapper li.css a span {
  background-image: url(../images/icon-css.png);
}

This patch moves the file to the correct location.
Let's see if it will work

Patch applies smoothly and it does what needs to be done to fix broken commit 0b06ac7cd5b600fc1a44a493926e68afac5a9484. IMO #31 should be committed and released ASAP, otherwise people would have to patch stable release for next couple of months or use dev release.

Ideally we would create follow-up issue for this kind of operation (fixing regressions introduced by the issue) but it's probably ok to just fix it here.

+1 for #31 being committed

+1 for the patch in comment #31 as well; it's working for us when testing in our Panopoly-based distribution.

+ another 1 for #31, it's been committed to Panopoly.

"Bump!" Two years on, this patch still works a treat for us, on a Panoply-based platform with over 250 sites.

This looks to be already committed in the dev release.