Entities may have varying revision keys (eg. vid, revision_id), these should be accounted for when loading an entity.

@see panelizer_panels_cache_get()

Solution:
Use revision key from entity info.

CommentFileSizeAuthor
#2 panelizer-2792907.patch1.44 KBmbm80
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mbm80 created an issue. See original summary.

mbm80’s picture

mbm80 CreditAttribution: mbm80 at drunomics commented
Status: Active » Needs review
FileSize
panelizer-2792907.patch1.44 KB

Added patch, please check.

mbm80’s picture

mbm80 CreditAttribution: mbm80 at drunomics commented
Assigned: mbm80 » Unassigned
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-3.3 » 7.x-3.x-dev
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2787147: Plan for Panelizer 7.x-3.5 release

That's a great catch, thank you!

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Patch works & is the right fix.
Bumping prio as customizing panel displays for every entity except node is broken without the fix!

  • DamienMcKenna committed 0166dcb on 7.x-3.x authored by mbm80 
    Issue #2792907 by mbm80: Don't assume entities use 'vid' as the revision...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.