If a default display is cloned the panes are given different 'pid' values but the UUID values are not reset.

CommentFileSizeAuthor
#12 panelizer-n2748373-11.patch542 bytesDamienMcKenna
#8 panelizer-n2748373-8.interdiff.txt542 bytesDamienMcKenna
#8 panelizer-n2748373-8.patch4.66 KBDamienMcKenna
#7 panelizer-n2748373-7.patch4.59 KBDamienMcKenna
#7 panelizer-n2748373-7.interdiff.txt1.62 KBDamienMcKenna
#5 panelizer-n2748373-5.interdiff.txt3.37 KBDamienMcKenna
#5 panelizer-n2748373-5.patch4.56 KBDamienMcKenna
#2 panelizer-n2748373-2.patch3.98 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
panelizer-n2748373-2.patch3.98 KB

This shows the problem exists.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Cloned default displays have duplicate UUID » Cloned default displays have duplicate UUIDs

Status: Needs review » Needs work

The last submitted patch, 2: panelizer-n2748373-2.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
panelizer-n2748373-5.patch4.56 KB
panelizer-n2748373-5.interdiff.txt3.37 KB

Slight refactoring.

Status: Needs review » Needs work

The last submitted patch, 5: panelizer-n2748373-5.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
panelizer-n2748373-7.interdiff.txt1.62 KB
panelizer-n2748373-7.patch4.59 KB

Some more refactoring.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
panelizer-n2748373-8.patch4.66 KB
panelizer-n2748373-8.interdiff.txt542 bytes

Disabling the comparison logic for now, will continue working on that later.

The last submitted patch, 7: panelizer-n2748373-7.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

I've committed #8 so I can reuse some of the code elsewhere, but the underlying bug needs to be fixed.

  • DamienMcKenna committed ca6b030 on 7.x-3.x 
    Issue #2748373 by DamienMcKenna: Tests to confirm defaults can be cloned...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
panelizer-n2748373-11.patch542 bytes

This shows the error.

Status: Needs review » Needs work

The last submitted patch, 12: panelizer-n2748373-11.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2253919: The UUIDs of cloned variant and relative panes are the same of original ones

I think this is actually caused by Panels, #2253919: The UUIDs of cloned variant and relative panes are the same of original ones will fix it.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

The patch in #2750545: New displays saved via panels_save_display() don't reset the UUID fixes this problem.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Postponed

Marking this postponed until #2750545: New displays saved via panels_save_display() don't reset the UUID is committed.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Postponed » Fixed

Going to handle the last bits in #2577031: Duplicated UUIDs after panelizer page override for specific node from node type template, so this can be closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.