It would be useful if the Panelizer system was weighted to take effect after the other Page Manager handlers. Currently the weight is set to -100, which effectively makes it show first, thus blocking all of the other Panels content type definitions, this should probably be set to 100 to load after them instead.

CommentFileSizeAuthor
#1 panelizer-n1290452-d6.patch1.16 KBDamienMcKenna
#1 panelizer-n1290452-d7.patch1.09 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
panelizer-n1290452-d7.patch1.09 KB
panelizer-n1290452-d6.patch1.16 KB

There isn't a good place to control this, so I just implemented a "hidden" variable called "panelizer_handler_weight", but I did at least document it in README.txt. Patches for D6 and D7 are included.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

The panelizer default is actually intended to process as early as possible by default so that it can be sure to process instead of other items. Moving it last seems like you would then be in danger of accidentally having panelized nodes fail to panelize because some other less important variant picks it up first. (Plus, you end up spending more resources calculating variants when you probably didn't mean to).

So I am not sure I think this change is correct.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Postponed

Perhaps #1268902: Selection rule doesn't seem to be a selection rule is the appropriate solution.

Marking postponed on this, we can come back and see if this is still needed after that is resolved.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Postponed » Closed (won't fix)

It seems highly unlikely to me that we need to change the weight now. The task was not letting non-panelized nodes through. That was a major bug; with that fixed, we want the panelizer task to be a high weight so that it will always panelize rather than let default node variants happen.