Problem/Motivation

If using as composer project, the modules could not be installed.

Proposed resolution

Extend the composer.json as in patch

CommentFileSizeAuthor
#3 3094283-additions_for_usable_composer_project-2.patch5.51 KBpvbergen
#2 3094283-additions_for_usable_composer_project.patch2.73 KBmetalbote

Comments

metalbote created an issue. See original summary.

metalbote’s picture

metalbote
Primary language German
Location Aachen
commented
StatusFileSize
new 3094283-additions_for_usable_composer_project.patch2.73 KB
pvbergen’s picture

pvbergen commented
Status: Active » Needs review
StatusFileSize
new 3094283-additions_for_usable_composer_project-2.patch5.51 KB

Thanks for the issue and patch, much appreciated.

Looks all fine to me, except for process-timout.
I would propose we omit the process-timeout config option (default 300 seconds).
I don't feel comfortable to allow processes to run indefinitely.

Did cloning hit the 300s limit in your case?

metalbote’s picture

metalbote
Primary language German
Location Aachen
commented

Ok, in this case i did not hit the 300s limit, but in most projects i do. Therefore i have set it in my defaults to 0. But i totally agree.