Service 'page_manager.variant_route_filter' for consumer 'router.no_access_checks' does not implement Drupal\Core\Routing\FilterInterface [#2955355]

Hi,

I found the related issue, but the patch won't work.

I get this;

root@vm:/home/luxcarcare/public_html/modules/page_manager# patch -p 1 < 2918564-22.patch
patching file page_manager.services.yml
1 out of 1 hunk ignored -- saving rejects to file page_manager.services.yml.rej
patching file src/Routing/RouteEnhancerCollectorTrait.php
Hunk #1 FAILED at 7 (different line endings).
Hunk #2 FAILED at 35 (different line endings).
Hunk #3 FAILED at 54 (different line endings).
Hunk #4 FAILED at 70 (different line endings).
4 out of 4 hunks FAILED -- saving rejects to file src/Routing/RouteEnhancerCollectorTrait.php.rej
patching file src/Routing/VariantRouteFilter.php
Hunk #1 FAILED at 1 (different line endings).
Hunk #2 FAILED at 25 (different line endings).
Hunk #3 FAILED at 141 (different line endings).
3 out of 3 hunks FAILED -- saving rejects to file src/Routing/VariantRouteFilter.php.rej
patching file tests/src/Unit/VariantRouteFilterTest.php
Hunk #1 FAILED at 14 (different line endings).
Hunk #2 FAILED at 331 (different line endings).
Hunk #3 FAILED at 375 (different line endings).
Hunk #4 FAILED at 436 (different line endings).
4 out of 4 hunks FAILED -- saving rejects to file tests/src/Unit/VariantRouteFilterTest.php.rej

Could anyone guide me though please?

Thanks in advance

Full error:

Symfony\Component\DependencyInjection\Exception\LogicException: Service 'page_manager.variant_route_filter' for consumer 'router.no_access_checks' does not implement Drupal\Core\Routing\FilterInterface. in Drupal\Core\DependencyInjection\Compiler\TaggedHandlersPass->processServiceCollectorPass() (line 164 of /home/luxcarcare/public_html/core/lib/Drupal/Core/DependencyInjection/Compiler/TaggedHandlersPass.php).
Drupal\Core\DependencyInjection\Compiler\TaggedHandlersPass->processServiceCollectorPass(Array, 'router.no_access_checks', Object) (Line: 97)
Drupal\Core\DependencyInjection\Compiler\TaggedHandlersPass->process(Object) (Line: 141)
Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object) (Line: 757)
Symfony\Component\DependencyInjection\ContainerBuilder->compile() (Line: 1307)
Drupal\Core\DrupalKernel->compileContainer() (Line: 884)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 466)
Drupal\Core\DrupalKernel->boot() (Line: 656)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comment	File	Size	Author
#3	page_manager-2955355-2.patch	1005 bytes	jadermecino

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 March 2018 at 19:54

MetalG created an issue. See original summary.

Comment #2

dravenk

He/Him

English

CreditAttribution: dravenk as a volunteer and at Google Summer of Code commented 23 March 2018 at 02:01

File	Size
page_manager-2955355-2.patch	1005 bytes

Comment #4

jadermecino CreditAttribution: jadermecino as a volunteer commented 23 March 2018 at 22:28

Status:

Active

» Needs work

Comment #5

espurnes

Catalan

CreditAttribution: espurnes as a volunteer commented 25 March 2018 at 17:18

I was getting the following message:
"[error] Service 'page_manager.variant_route_filter' for consumer 'router.no_access_checks' does not implement Drupal\Core\Routing\FilterInterface."

and "2918564-22.patch" didn't solved the problem.

it seems #3 do solves the problem.

thankyou jadermecino.

Comment #6

Nigel Cunningham

Geelong

CreditAttribution: Nigel Cunningham at Grindstone Creative commented 25 March 2018 at 21:57

Status:

Needs work

» Reviewed & tested by the community

Successfully tested here.

Comment #7

Berdir

German

Switzerland

CreditAttribution: Berdir commented 25 March 2018 at 23:22

Priority:	Major	» Normal
Status:	Reviewed & tested by the community	» Postponed (maintainer needs more info)

There have been several fixes already in the 8.x-4.x-dev branch, the patch also didn't apply and therefore can't be RTBC.

Before reporting a bug, always check the dev branch first. Any changes is made in the dev branch first.

Comment #8

Nigel Cunningham

Geelong

CreditAttribution: Nigel Cunningham at Grindstone Creative commented 25 March 2018 at 23:05

Ah... you still have the 8.x-1.x branch as the default when you check out the git repo. Could I persuade you to change that to the current tip so people don't make the same mistake in future?

git checkout -b 8.x-4.x remotes/origin/8.x-4.x

gives me a branch that doesn't cause any errors on cache clear etc. Thanks.

Comment #9

MetalG CreditAttribution: MetalG commented 28 March 2018 at 17:16

How do I apply this #3? I'm kinda not used to do this : )

Comment #10

markie CreditAttribution: markie at Mediacurrent commented 28 March 2018 at 23:41

Can confirm #3 applies cleanly against the latest beta pulled in from composer. For more information on how to apply a patch, see https://www.drupal.org/patch/apply

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 29 March 2018 at 11:27

Version:

8.x-4.0-beta2

» 8.x-4.x-dev

Comment #12

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 29 March 2018 at 14:37

Version:	8.x-4.x-dev	» 8.x-4.0-beta2
Status:	Postponed (maintainer needs more info)	» Fixed

If this has been fixed elsewhere then lets just mark this one "fixed".

Comment #13

techbuilders CreditAttribution: techbuilders commented 29 March 2018 at 22:44

Will someone please be kind enough to let us know the folder path to apply the patch?

Thanks in advance!

Comment #14

markie CreditAttribution: markie at Mediacurrent commented 29 March 2018 at 22:54

All patches are usually created relative to the module root. So, in most cases, for this module, /path_to_site_root/modules/contrib/page_manager. This is also noted in the first line of the patch

a/src/Routing/VariantRouteFilter.php b/src/Routing/VariantRouteFilter.php

This is all documented at https://www.drupal.org/patch/apply.

Personally, I find using Composer to apply patches for me to be the easiest. See http://www.anexusit.com/blog/how-to-apply-patches-drupal-8-composer

Comment #15

arosboro CreditAttribution: arosboro at DropForge Labs commented 30 March 2018 at 10:07

Just noticed this was not fixed in beta2 for me. I had to apply patch #3 and everything worked. Thanks for the contribution @jadermecino

Comment #16

vishusrinivasan CreditAttribution: vishusrinivasan commented 5 April 2018 at 10:49

Can confirm Patch #3 worked for me.

Comment #17

techbuilders CreditAttribution: techbuilders commented 6 April 2018 at 14:37

Thanks @markie #3 worked

Comment #18

vurt CreditAttribution: vurt as a volunteer and at Computer Manufaktur GmbH commented 10 April 2018 at 13:14

The error appeared when I switched from Drupal Core 8.4 to 8.5.

Patch #3 fixed the problem. Thanks!

Comment #19

manuel.adan

🌌

CreditAttribution: manuel.adan at Arcovía Digital for Asociación TecnoAriadna commented 20 April 2018 at 11:06

Status:	Fixed	» Closed (duplicate)
Related issues:		+#2918564: Update 'page_manager.variant_route_filter' service according to core changes

Dup of #2918564: Update 'page_manager.variant_route_filter' service according to core changes

Comment #20

KVF-IT CreditAttribution: KVF-IT commented 9 July 2018 at 15:03

When I try to add Patch #3 I get

Hunk #1 FAILED at 11.
Hunk #2 Failed at 25.
2 out of 2 hunks FAILED -- saving rejects to file src/Routing/VariantRouteFilter.php.rej

Comment #21

KVF-IT CreditAttribution: KVF-IT commented 9 July 2018 at 15:12

When I try to add Patch 2918564-22.patch I get

Hunk #1 FAILED at 27.
1 out of 1 hunk FAILED -- saving rejects to file page_manager.services.yml.rej
patching file src/Routing/RouteEnhancerCollectorTrait.php
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 35.
Hunk #3 FAILED at 54.
Hunk #4 FAILED at 70.
4 out of 4 hunks FAILED -- saving rejects to file src/Routing/RouteEnhancerCollectorTrait.php.rej
patching file src/Routing/VariantRouteFilter.php
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 25.
Hunk #3 FAILED at 141.
3 out of 3 hunks FAILED -- saving rejects to file src/Routing/VariantRouteFilter.php.rej
patching file tests/src/Unit/VariantRouteFilterTest.php
Reversed (or previously applied) patch detected! Assume -R? [n] y
intranet:/var/www/intranet/modules/page_manager$ sudo patch -p 1 < 2918564-22.patch
patching file page_manager.services.yml
Reversed (or previously applied) patch detected! Assume -R? [n] y
patching file src/Routing/RouteEnhancerCollectorTrait.php
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 35.
Hunk #3 FAILED at 54.
Hunk #4 FAILED at 70.
4 out of 4 hunks FAILED -- saving rejects to file src/Routing/RouteEnhancerCollectorTrait.php.rej
patching file src/Routing/VariantRouteFilter.php
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 25.
Hunk #3 FAILED at 141.
3 out of 3 hunks FAILED -- saving rejects to file src/Routing/VariantRouteFilter.php.rej
patching file tests/src/Unit/VariantRouteFilterTest.php

Comment #22

KVF-IT CreditAttribution: KVF-IT commented 13 July 2018 at 09:08

Got it fixed!

Was using Drupal 8.4.2, and Page Manager 8.x-4.o-beta3.

Uninstalled Page Manager, and installed Page Manager 8.x-4.o-beta2, and it worked out.

Comment #23

mcdeltat CreditAttribution: mcdeltat commented 26 September 2018 at 21:12

Since I can't comment on any of the duplicate issues, it seems that this problem may still be affecting me on 8.6.1. I was stuck with some composer stuff, deleted my composer.lock and vendor directories and installed again, and now get this error. So is this fixed? I'm slightly new to Drupal so is Page Manager a part of drupal/core? Why am I not seeing when running composer show?

Relevant parts of my composer.json:

"require": {
        "composer/installers": "^1.0.24",
        "wikimedia/composer-merge-plugin": "^1.4",
        "rlanvin/php-rrule": "1.*",
	"drupal/core": "^8.6",
        "drush/drush": "^9.4",
	"symfony/yaml": "^3.4"
    },
    "minimum-stability": "dev",

So according to all the other pages this shouldn't be affected me? It seemed like this was patched in 8.5.x no?