Use context in variant JS to be compatible with BigPipe

Given that BigPipe is now enabled automatically in 8.5.x, this needs to be resolved soon.

Not only context, once() is missing as well. Here's the patch.

The last non-failing test run was at Aug 2017 and none of the tests provides JS and/or browser tests, so ignoring test resutls should be safe.

Hi, seems duplicated, the same was reported there https://www.drupal.org/project/page_manager/issues/2951961

TODO: Check if jquery once library is included as dependency.

Yes, library missing "once" dependency https://cgit.drupalcode.org/page_manager/tree/page_manager_ui/page_manag...

Patch to add dependence for jquery once, Thanks @abramm for the review in the other thread.

+++ b/page_manager_ui/page_manager_ui.libraries.yml
@@ -12,3 +12,4 @@ page_variants:
     - core/jquery
+    - core/jquery.once

later depends on jquery, so jquery should be removed)

Updated!

#16 works for me thanks.

I've been using #16 for a month without any issues.

#16 tested and works well! :)

#16 works for me, please commit this.
Drupal version: 8.5.3

Bump.

Hi,

I got this issue in drupal 8.5.3(current version).
When you select edit of your respective page,the sub menu of the variants are not seen.I have attached a screenshot of it.
I inspected the element and found that (display:none) has been given for the ul element (please see screenshot).
So, commenting that class worked for me.

File path: page_manager->page_manager_ui->css->page-manager-ui-page-variants.css
(Line number 6)
Styling:
.page-manager-wizard-tree .page__section__2 {
display: none;
}

I commented the above styling and it worked for me.

Hi @krith_18,

What you see is symptoms of JS behavior issue.
The patch at #5/#16 (which is essentially the same) is intended to fix this issue. Just apply and clear your caches.
Please let me know if this helps.

Hi @abramm,

I tried applying patch #5 and #16 but it is not working for me.
Is removing display:none a wrong way of doing?

Thanks in advance!

16 works perfectly for me. +1 RTBC

#16 works for me too. +1 RTBC.

Hate to rain on the RTBC, but the patch isn't working for me on 8.5.6. I tried both the latest dev and beta versions. If I turn BigPipe off, Variants open again; so it is the same problem/solution.

I'm running 8.5.6 with Page Manager 8.x-4.0-beta3, plus this patch and two additional patches:

https://www.drupal.org/project/page_manager/issues/2458563#comment-12000506
https://www.drupal.org/project/page_manager/issues/2858877#comment-12660287

BigPipe is enabled, and my variants are functioning correctly.

I wonder how your setup is different?

Thank you for your setup info. I have no other patches for Page Manager applied. I'll troubleshoot this further if I have time.

One thing I know for sure: it's not just BigPipe. When I first started using Page Manager I didn't have this problem, and BigPipe has always been enabled in my setup. Something else is causing the issue and turning BigPipe off just happens to fix it.

Hi @fatmarker,

You may be seeing some other JS issue caused by BigPipe, not necessary this one. Try checking your browser JS console.

Could you please try reproducing the issue with a patch applied on a clean Drupal install (simplytest.me is an option)?
If it reproduces, please post exact steps to reproduce so someone else could check it as well.
If it not reproduces with clean install, there's something else specific for your installation. In this case, please change this issue status back to RTBC.

Thanks!

Patch works. Sorry for all the hoopla... =[

So strange. After patching I cleared the cache multiple times — didn't work. Rolled back a bunch of composer updates and 1 module updated from this morning (clearing cache in between) — still didn't work. Then started upgrading things again one by one, and it suddenly started working. I think I just needed to clear the cache 10 more times. Sorry!!

What confuses me the most is that I didn't have this variants issue or a need for this patch a few weeks ago, and BigPipe has always been enabled.

Hi,

I have page manager 8.x-4.0-beta3 on drupal 8.5.6. When trying to add/edit or delete blocks nothing is happening and it is the same when I try to delete the variant on the "general" tab.

I can see the following errors in the Safari console:
[Error] TypeError: undefined is not a function (near '...a.widget...')
(fonction anonyme) (Élément de script 1:4:172)
(fonction anonyme) (Élément de script 1:4:135)
Code général (Élément de script 1:4:144)
appendChild
p (jquery.min.js:2:535)
globalEval (jquery.min.js:2:2583)
text script (jquery.min.js:4:17047)
Qb (jquery.min.js:4:10178)
A (jquery.min.js:4:13722)
(fonction anonyme) (jquery.min.js:4:16325)
send
send (jquery.min.js:4:16675)
ajax (jquery.min.js:4:13507)
Ja (jquery.min.js:3:15822)
insert (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:130)
(fonction anonyme) (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:121:295)
forEach
success (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:121:186)
success (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:105)
i (jquery.min.js:2:28023)
fireWith (jquery.min.js:2:28785)
A (jquery.min.js:4:14047)
(fonction anonyme) (jquery.min.js:4:16325)
[Error] TypeError: undefined is not a function (near '...a.widget...')
(fonction anonyme) (Élément de script 2:4:182)
(fonction anonyme) (Élément de script 2:4:145)
Code général (Élément de script 2:4:154)
appendChild
p (jquery.min.js:2:535)
globalEval (jquery.min.js:2:2583)
text script (jquery.min.js:4:17047)
Qb (jquery.min.js:4:10178)
A (jquery.min.js:4:13722)
(fonction anonyme) (jquery.min.js:4:16325)
send
send (jquery.min.js:4:16675)
ajax (jquery.min.js:4:13507)
Ja (jquery.min.js:3:15822)
insert (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:130)
(fonction anonyme) (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:121:295)
forEach
success (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:121:186)
success (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:105)
i (jquery.min.js:2:28023)
fireWith (jquery.min.js:2:28785)
A (jquery.min.js:4:14047)
(fonction anonyme) (jquery.min.js:4:16325)
[Error] TypeError: undefined is not a function (near '...$.widget...')
(fonction anonyme) (Élément de script 3:7)
Code général (Élément de script 3:8:182)
appendChild
p (jquery.min.js:2:535)
globalEval (jquery.min.js:2:2583)
text script (jquery.min.js:4:17047)
Qb (jquery.min.js:4:10178)
A (jquery.min.js:4:13722)
(fonction anonyme) (jquery.min.js:4:16325)
send
send (jquery.min.js:4:16675)
ajax (jquery.min.js:4:13507)
Ja (jquery.min.js:3:15822)
insert (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:130)
(fonction anonyme) (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:121:295)
forEach
success (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:121:186)
success (js_rlKs-XcNqAu9EFy1vVfPA1k_Kymrz1mGRfwkizcRku0.js:105)
i (jquery.min.js:2:28023)
fireWith (jquery.min.js:2:28785)
A (jquery.min.js:4:14047)
(fonction anonyme) (jquery.min.js:4:16325)

I have installed the 2921404-16.patch but nothing better...

Thanks in advance,

@Prez13 please file separate issue for Safari, this one about different bug

Tested and works.

tested & it works ;)

What do we need here to get this committed?

#16 tested and works.

Hi,
none of the provided patches worked for me.
Commenting out

.page-manager-wizard-tree .page__section__2 {
  display: none;

from #24
worked!

thanks
Vincent

#16 worked for me as well. Thank you everyone!

Patch in #16 resolved this issue for me on 8.6.7 with 8.x-4.0-beta3

#16 tested and works.

The patch #16 looks good and applies successfully. +1 for RTBC.

The patch #16 looks good and applies successfully. +1 for RTBC.

It works, but aggregated JavaScript files has to be regenerated to take the changes, added cache clearing on post update.

Committed, thanks to everyone!

Problem still exists with Drupal 8.8.2.