For hiding the overlay the class '.hidden' is used. This can conflict with other front end implementations that also use '.hidden' and toggle visibility with Javascript.

It would be better to change the class to '.page-load-hidden' to reflect that the desired functionality is only intended for this module.

Attached is a patch

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

breidert created an issue. See original summary.

breidert’s picture

maikelfinck’s picture

Patch looks OK.

Just I don't think this is a bug as the module works fine. The issue here is coexistence with other modules so I think this is an improvement.

Also, it may be better to follow the module name if you are going to change the class. Like page-load-progress-hidden instead of page-load-hidden.

maikelfinck’s picture

Status: Active » Needs review
FileSize
1.01 KB

@breidert, I've applied your patch and updated the class name. This is the new patch.

anavarre’s picture

Version: 7.x-1.3 » 7.x-1.x-dev
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Flagging this as a bug seems fine with me since it can cause issues with other implementations. Code looks okay and I agree the convention needs to be page-load-progress-<classname>. We will need to make the change to the 8.x-1.x branch as well.

breidert’s picture

cool :-)

  • anavarre committed 07437a9 on 7.x-1.x authored by maikelfinck
    Issue #2831192 by breidert, maikelfinck: CSS class '.hidden' conflicts...

  • anavarre committed 0f94a7a on 8.x-1.x authored by breidert
    Issue #2831192 by breidert, maikelfinck, anavarre: CSS class '.hidden'...
anavarre’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x which allowed me to credit you both. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.