Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
For hiding the overlay the class '.hidden' is used. This can conflict with other front end implementations that also use '.hidden' and toggle visibility with Javascript.
It would be better to change the class to '.page-load-hidden' to reflect that the desired functionality is only intended for this module.
Attached is a patch
Comment | File | Size | Author |
---|---|---|---|
#4 | page_load_progress-2831192.patch | 1.01 KB | maikelfinck |
#2 | page_load_progress_class_hidden-2831192-11800199.patch | 1019 bytes | breidert |
Comments
Comment #2
breidert CreditAttribution: breidert at 1xINTERNET commentedComment #3
maikelfinck CreditAttribution: maikelfinck at CI&T commentedPatch looks OK.
Just I don't think this is a bug as the module works fine. The issue here is coexistence with other modules so I think this is an improvement.
Also, it may be better to follow the module name if you are going to change the class. Like
page-load-progress-hidden
instead ofpage-load-hidden
.Comment #4
maikelfinck CreditAttribution: maikelfinck at CI&T commented@breidert, I've applied your patch and updated the class name. This is the new patch.
Comment #5
anavarreFlagging this as a bug seems fine with me since it can cause issues with other implementations. Code looks okay and I agree the convention needs to be
page-load-progress-<classname>
. We will need to make the change to the 8.x-1.x branch as well.Comment #6
breidert CreditAttribution: breidert at 1xINTERNET commentedcool :-)
Comment #9
anavarreCommitted to 7.x and 8.x which allowed me to credit you both. Thanks!