Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The basics work and it will now need to implement the missing JS bit. E.g.
Comment | File | Size | Author |
---|---|---|---|
#11 | apply_esc_key_abord_locking--2779741-11.patch | 6.12 KB | Dom. |
#9 | interdiff.txt | 2.5 KB | anavarre |
#7 | interdiff.txt | 1.93 KB | Dom. |
#7 | esc_key_abord_locking--2779741-7.patch | 6.03 KB | Dom. |
escape-throbber.patch | 5.16 KB | anavarre | |
Comments
Comment #2
anavarreTests are passing. Putting back to Needs Work per the issue summary.
Comment #3
anavarreComment #4
anavarreComment #5
Dom. CreditAttribution: Dom. as a volunteer and at ACINO commentednewline is also needed on yml files (for instance, see #2521774: Add new line at the EOF in system_test.permissions.yml file).
Could we change this to something less frightening that "our module may not work" ? Maybe : 'This module locks screen during a form submission process. Under some circunstances, you may want to let your user unlock the screen manually by pressing ESC key.'
Now time to actually use this config ?! ^^
Comment #6
Dom. CreditAttribution: Dom. as a volunteer and at ACINO commentedwon't work since hook_page_attachments attachs the config under the name 'esc' while the JS try to get it under name 'esc_key'
Comment #7
Dom. CreditAttribution: Dom. as a volunteer and at ACINO commentedPatch attached to actually kill the locking with ESC key.
Comment #8
anavarreNot stricly in scope for this issue but what about: "Add the screen lock behavior for each configured element."
Can we simplify this to: "Allows ESC key to kill the throbber"?
Looks like doing this might be outdated. See http://stackoverflow.com/questions/3369593/how-to-detect-escape-key-pres...
Not sure about the coding standards for this JS dockblock. Any idea if we're missing a new line or anything?
I agree the initial verbiage might have been too strong. I like your wording better, but I'd drop "This module locks screen during a form submission process." completely because it's essentially what the whole module is doing.
Comment #9
anavarreAlso, re-uploading the interdiff for better readability.
Comment #10
anavarreFYI I've just tested the patch against D8, to reproduce #1818872: Cant edit views with .form-submit element enabled. and it works great. I can now easily kill the throbber when editing a view makes the throbber spins forever.
Comment #11
Dom. CreditAttribution: Dom. as a volunteer and at ACINO commentedComment #13
anavarreTested the patch and it works well. Backwards compatibility is also good to have. This is what we need for now. Thanks!