We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation.

CommentFileSizeAuthor
#4 Screenshot.png58.18 KBBushra Shaikh

Issue fork outvoice-3322156

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pracheth created an issue. See original summary.

Pracheth opened merge request !1

Pracheth’s picture

Pracheth commented
Assigned: Pracheth » Unassigned
Status: Active » Needs review
Bushra Shaikh’s picture

Bushra Shaikh commented
StatusFileSize
new Screenshot.png58.18 KB

I verified and applied MR !1 for Drupal version 10.0.2.
README.txt file updated to README.md after applying MR but got some warning
Adding screenshots for reference:

1.diff.patch:817: trailing whitespace.
    form_set_error('outvoice', t("Please enter an amount larger than $1. To publish without using outvoice,
1.diff.patch:825: trailing whitespace.
    form_set_error('outvoice', t("You are not authorized for amounts greater than $10000. To publish without using outvoice,
warning: 2 lines add whitespace errors.
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Anjali Mehta made their first commit to this issue’s fork.

anjali mehta’s picture

anjali mehta commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!1, the patch still has some issues.

1.diff.txt:816: trailing whitespace.
    form_set_error('outvoice', t("Please enter an amount larger than $1. To publish without using outvoice,
1.diff.txt:824: trailing whitespace.
    form_set_error('outvoice', t("You are not authorized for amounts greater than $10000. To publish without using outvoice,
1.diff.txt:216: new blank line at EOF.
+
warning: 3 lines add whitespace errors.
anjali mehta’s picture

anjali mehta commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR!1, the file is updated as per readme.md file template.
Hence marking it to RTBC.